Add Flag to Disable Push to Container Registry #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyawadhwa
reviewed
Aug 17, 2018
|
I'm also curious how you plan to use this flag in CI? If the image isn't saved anywhere, it can't be tested or used in later steps. Are you just trying to verify the build works? |
|
Hi @priyawadhwa, yeah; I'll update the README. As for your question - yeah. We want to |
|
Cool, thanks for clarifying! |
The flag, `--no-push`, is added to allow building a container image without pushing to a container registry. It can be common, especially with multi-stage builds and `--target`, to build enough to run the tests, and then perform a push in a separate CI step. This will facilitate these workflows.
rawkode
force-pushed
the
feature/allow-build-only
branch
from
82b9c99
to
4535039
Compare
|
@priyawadhwa |
priyawadhwa
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag,
--no-push, is added to allow building a container imagewithout pushing to a container registry. It can be common, especially
with multi-stage builds and
--target, to build enough to run the tests,and then perform a push in a separate CI step. This will facilitate these
workflows.