-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #944 include docker-credential-acr-linux #945
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it!
…On 3 Jan 2020, 10:50 +0100, GoogleContainerTools/kaniko ***@***.***>, wrote:
@googlebot I signed it!
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@@ -23,6 +23,9 @@ RUN docker-credential-gcr configure-docker | |||
# Get Amazon ECR credential helper | |||
RUN go get -u github.com/awslabs/amazon-ecr-credential-helper/ecr-login/cli/docker-credential-ecr-login | |||
RUN make -C /go/src/github.com/awslabs/amazon-ecr-credential-helper linux-amd64 | |||
# ACR docker credential helper | |||
ADD https://aadacr.blob.core.windows.net/acr-docker-credential-helper/docker-credential-acr-linux-amd64.tar.gz /usr/local/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we lock this to a specific version of the credential helper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as i can see this tool does not have releases / version numbers yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya that's what I see too, bummer. Hopefully we won't have too many problems with updates
Fixes #944 . in case of a bug fix, this should point to a bug and any other related issue(s)
Description
includes docker-credential-acr-linux in the docker image.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.