Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata event emission to happen every devloop and update build metadata #5918

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5843

Description
Updates the metadata event to include more useful information about build artifacts.
Also changes the emission to happen every devloop, as the metadata could change in between loops.

Follow-up Work (remove if N/A)
Updates to the deploy information will be made in a follow up.

@MarlonGamez MarlonGamez requested a review from a team as a code owner May 27, 2021 22:13
@google-cla google-cla bot added the cla: yes label May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #5918 (46a7610) into master (f477f48) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5918      +/-   ##
==========================================
+ Coverage   70.92%   70.93%   +0.01%     
==========================================
  Files         449      449              
  Lines       16974    16981       +7     
==========================================
+ Hits        12039    12046       +7     
  Misses       4038     4038              
  Partials      897      897              
Impacted Files Coverage Δ
pkg/skaffold/event/v2/metadata.go 88.57% <85.18%> (ø)
pkg/skaffold/runner/v1/dev.go 72.43% <100.00%> (+0.60%) ⬆️
pkg/skaffold/runner/v1/new.go 64.28% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f477f48...46a7610. Read the comment docs.

@MarlonGamez MarlonGamez merged commit f7289a5 into GoogleContainerTools:master Jun 1, 2021
@tejal29 tejal29 mentioned this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants