fixes #9 #10
Merged
fixes #9 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update upstream changes
…nd fix severe bug
merge upstream changesa
…tion that is currently happening make everything groovy remove unused code
|
I was going to do this today as we had to switch to a Jedis scan vs key and I realized that the connection needs an explicit close. Will review asap. |
|
sorry wrong button :) |
|
We really need more tests around this thing.... releasing now 1.1.9. |
|
#thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix #9
I groovyfied the WorkerImpl as i had to touch a lot of code anyways.
As soon as gresrun/jesque#109 we should consider getting rid of that "custom" WorkerImpl completly and use the original WorkerPoolImpl.
I also cleaned up some stuff that was never used in the custom WorkerImpl