Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grpcio #139

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Upgrade grpcio #139

wants to merge 12 commits into from

Conversation

Jongy
Copy link
Contributor

@Jongy Jongy commented Apr 15, 2023

No description provided.

protobuf~=3.19.4
docker~=5.0.0
dataclasses~=0.8; python_version < '3.7'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer support 3.7 so this is not required.

requirements.txt Outdated
@@ -1,9 +1,8 @@
psutil~=5.8.0
requests~=2.27.1
grpcio~=1.43.0
grpcio~=1.53.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main motive for it is upgrading gprofiler to python 3.11 which requires newer grpcio.

@Jongy
Copy link
Contributor Author

Jongy commented Apr 15, 2023

Pending test - I will run gProfiler on a box which runs k8s CRI and ensure gProfiler is able to use the ContainersClient (CRI) with the new grpc version.

@Jongy Jongy changed the title Upgrade packages, take 2 Upgrade packages, part 1 Apr 15, 2023
@Jongy Jongy changed the title Upgrade packages, part 1 Upgrade grpcio Apr 17, 2023
@Jongy
Copy link
Contributor Author

Jongy commented Jun 21, 2023

I am waiting for next grcpio releases to ensure it doesn't hang gProfiler anymore.

@Jongy Jongy mentioned this pull request Jun 21, 2023
This was referenced Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants