Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/granulate utils filter filters typo #243

Merged
merged 1 commit into from
May 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions granulate_utils/containers/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ def __init__(self) -> None:
self._docker = docker.DockerClient(base_url="unix://" + ns.resolve_host_root_links(DOCKER_SOCK))

def list_containers(self, all_info: bool, only_running: bool = True) -> List[Container]:
container_filter = None
container_filters = None
Jongy marked this conversation as resolved.
Show resolved Hide resolved
if only_running:
container_filter = {"status": "running"}
container_filters = {"status": "running"}

containers = self._docker.containers.list(
ignore_removed=True,
filter=container_filter,
filters=container_filters,
Jongy marked this conversation as resolved.
Show resolved Hide resolved
) # ignore_removed to avoid races, see my commit
return list(map(self._create_container, containers))

Expand Down
Loading