Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cgroup2: remove bogus assumptions about cgroup mounts #247

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

glipner
Copy link
Contributor

@glipner glipner commented Jun 11, 2024

Cgroup2 detection used to look for a single mount point, that had been mounted as mount -t cgroup2 *cgroup2* <path> (without the *s).
In particular, there were two erroneous assumptions made: that the object being mount (in between * signs) is always called cgroup2, and that there might only be one cgroup2 mount present.
We've encountered case where neither of these assumptions held.

This commit removes them.

@glipner glipner self-assigned this Jun 11, 2024
@glipner glipner marked this pull request as ready for review June 11, 2024 07:31
@glipner glipner requested a review from michelhe June 11, 2024 07:31
Copy link
Contributor

@michelhe michelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glipner glipner merged commit afb7729 into master Jun 11, 2024
7 checks passed
@glipner glipner deleted the cgroup2-bugfix branch June 11, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants