Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/revert wrongfully deleted files #258

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

odelame
Copy link
Contributor

@odelame odelame commented Aug 14, 2024

No description provided.

@odelame odelame requested a review from michelhe August 14, 2024 11:51
michelhe
michelhe previously approved these changes Aug 14, 2024
Copy link
Contributor

@michelhe michelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted by accident on #257 , right?

@odelame
Copy link
Contributor Author

odelame commented Aug 14, 2024

Deleted by accident on #257 , right?

Yes

@Jongy
Copy link
Contributor

Jongy commented Aug 14, 2024

Can you please create a PR in gProfiler that points to this commit, and ensure gProfiler builds & the tests pass? (then we can merge this & the gProfiler PR).

@grariel
Copy link
Contributor

grariel commented Aug 19, 2024

@odelame @michelhe what about this? It blocks @gAmitFrenkel

@odelame
Copy link
Contributor Author

odelame commented Aug 20, 2024

Based on Granulate/gprofiler#915 we can merge

@odelame odelame requested a review from Jongy August 20, 2024 10:49
@Jongy Jongy merged commit 80a9dda into master Aug 20, 2024
7 checks passed
@Jongy Jongy deleted the bugfix/revert-wrongfully-deleted-files branch August 20, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants