Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s container annotations #260

Merged
merged 6 commits into from
Aug 22, 2024
Merged

K8s container annotations #260

merged 6 commits into from
Aug 22, 2024

Conversation

gAmitFrenkel
Copy link
Contributor

@gAmitFrenkel gAmitFrenkel commented Aug 20, 2024

Create a derived class of container to access the container annotations pulled by the cri client.

@Jongy
Copy link
Contributor

Jongy commented Aug 20, 2024

make sure to merge it to master eventually, not to that branch 😅

Base automatically changed from bugfix/revert-wrongfully-deleted-files to master August 20, 2024 12:35
@grariel
Copy link
Contributor

grariel commented Aug 21, 2024

Please test on gProfiler before you merge. Wait for this PR to be merged first so that gProfiler's CI will be back.

@grariel grariel merged commit 612e39d into master Aug 22, 2024
7 checks passed
@grariel grariel deleted the k8s_container_annotations branch August 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants