Enable option to use custom mjml parser instead of default one #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelstencl
force-pushed
the
custom-parser
branch
from
f7c67b9
to
ebac70c
Compare
|
@artf This is a good option to use. Why can't you merge and approve this? I am also looking forward to using custom MJML components." |
|
@pavelstencl Having Complete Demo is Great |
artf
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Thanks @pavelstencl this is an awesome addition.
Sorry if it took some much time to finally merge it 😓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @artf ,
Thank you for your repository. It's fantastic! We've implemented our custom MJML-browser parser with additional components, but we're encountering issues using it in GrapesJS/mjml.
So I've included an option in the GrapesJS/mjml plugin config to override the default MJML parser. Would it be feasible to incorporate this feature into your package?
Thanks and cheers!