-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PWA theme-color for frontend to adhere to system theme #1716
Change PWA theme-color for frontend to adhere to system theme #1716
Conversation
Your PR changes the indentation to tabs in one, but not both, files. Could you please either make them both tabs or keep them as both spaces? |
Thanks for the heads up, done. |
Except now you replaced all the indentation in index.html... |
Ah sorry. Let me just fix that. I must've accidentally configured the indentations to be more like rust's way for that too. Fixed now. Thank you for the patience 🙏 |
Where did you find that |
Stumbled across this as a fix that could work for PWAs by just trying it. It seemed to work on my end, and the PWA would change the title bar color in accordance with the theme. But yes, I agree that it doesn't seem to be a widely supported option and the issue you mentioned is definitely worth looking in to. I'll be on the lookout for a better solution with regards to the issue you mentioned, but this PR should indeed remain closed for now. Thanks! |
Resolves #1338