refactor: code cleanup #2519
Draft
refactor: code cleanup #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collections.sort is just a wrapper, so it is better to use an instance method directly.
we can use computeIfAbsent here
gabriel-logan
approved these changes
Jun 9, 2024
gabriel-logan
approved these changes
Jun 9, 2024
Bumps [com.google.protobuf:protoc](https://github.com/protocolbuffers/protobuf) from 3.18.1 to 4.27.1. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: com.google.protobuf:protoc dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.14.0 to 2.17.1. - [Commits](FasterXML/jackson-bom@jackson-bom-2.14.0...jackson-bom-2.17.1) --- updated-dependencies: - dependency-name: com.fasterxml.jackson:jackson-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.jline:jline-terminal-jna](https://github.com/jline/jline3) from 3.21.0 to 3.26.1. - [Release notes](https://github.com/jline/jline3/releases) - [Changelog](https://github.com/jline/jline3/blob/master/changelog.md) - [Commits](jline/jline3@jline-parent-3.21.0...jline-parent-3.26.1) --- updated-dependencies: - dependency-name: org.jline:jline-terminal-jna dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.junit.jupiter:junit-jupiter-engine](https://github.com/junit-team/junit5) from 5.8.2 to 5.10.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.8.2...r5.10.2) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-engine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…otobuf-protoc-4.27.1 chore(deps): bump com.google.protobuf:protoc from 3.18.1 to 4.27.1
….jackson-jackson-bom-2.17.1 chore(deps): bump com.fasterxml.jackson:jackson-bom from 2.14.0 to 2.17.1
…ne-terminal-jna-3.26.1 chore(deps): bump org.jline:jline-terminal-jna from 3.21.0 to 3.26.1
…iter-junit-jupiter-engine-5.10.2 chore(deps): bump org.junit.jupiter:junit-jupiter-engine from 5.8.2 to 5.10.2
Bumps [org.java-websocket:Java-WebSocket](https://github.com/TooTallNate/Java-WebSocket) from 1.5.2 to 1.5.6. - [Release notes](https://github.com/TooTallNate/Java-WebSocket/releases) - [Changelog](https://github.com/TooTallNate/Java-WebSocket/blob/master/CHANGELOG.md) - [Commits](TooTallNate/Java-WebSocket@v1.5.2...v1.5.6) --- updated-dependencies: - dependency-name: org.java-websocket:Java-WebSocket dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ch.qos.logback:logback-core](https://github.com/qos-ch/logback) from 1.4.7 to 1.5.6. - [Commits](qos-ch/logback@v_1.4.7...v_1.5.6) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…k-logback-core-1.5.6 chore(deps): bump ch.qos.logback:logback-core from 1.4.7 to 1.5.6
…ocket-Java-WebSocket-1.5.6 chore(deps): bump org.java-websocket:Java-WebSocket from 1.5.2 to 1.5.6
Bumps org.slf4j:slf4j-api from 2.0.7 to 2.0.13. --- updated-dependencies: - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…4j-api-2.0.13 chore(deps): bump org.slf4j:slf4j-api from 2.0.7 to 2.0.13
Sauloyo
approved these changes
Jul 8, 2024
Hartie95
reviewed
Jul 10, 2024
| @@ -113,7 +113,7 @@ public void handle(GameSession session, byte[] header, byte[] payload) throws Ex | |||
| if (req.getKeyId() > 0) { | |||
| var encryptSeed = session.getEncryptSeed(); | |||
| try { | |||
| var cipher = Cipher.getInstance("RSA/ECB/PKCS1Padding"); | |||
| var cipher = Cipher.getInstance("RSA/ECB/OAEPWithSHA-256AndMGF1Padding"); | |||
There was a problem hiding this comment.
Did you verify that this is compatible with the client or just apply suggestions from sonarcloud?
Because this has a high chance of breaking the ps. Same for the other crypto algorithm changes.
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| @ResourceType(name = "RewardPreviewExcelConfigData.json", loadPriority = LoadPriority.HIGH) | |||
| public class RewardPreviewData extends GameResource { | |||
| @Getter(onMethod_ = @Override) | |||
| @Getter(onMethod = @__(@Override)) | |||
There was a problem hiding this comment.
why the use of the legacy on method annotation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please carefully read the Contributing note and Code of conduct before making any pull requests.
Issues fixed by this PR
Type of changes
Checklist: