Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Not Updated Across Page Elements After Installation or Activation #2117

Open
Mwalek opened this issue Aug 19, 2024 · 2 comments
Open
Assignees
Labels

Comments

@Mwalek
Copy link

Mwalek commented Aug 19, 2024

After performing installation, activation, or purchase actions on any element within the View edit page, such as through the layout dropdown or settings metabox placeholders, the state of all relevant page elements should be updated to reflect the latest changes.

Currently, this state update is not consistently applied across all page elements, leading to discrepancies in the displayed status.

For example, when a layout is installed from the main area of the GUI, the "View type" dropdown does not update to reflect the installation. The dropdown should no longer show an "install" button for the layout that has just been installed, but currently, it does.

Steps to Reproduce:

  1. Create a new View.
  2. Enter a title for the View.
  3. Select a form to connect to the View.
  4. Choose a View type that is not already installed by clicking the "Install" button from the main area.
  5. Perform an installation, activation, or purchase action for a plugin or View type.
  6. Check the layout dropdown and the settings metabox placeholders for any inconsistencies.

Expected Behavior:

After any installation, activation, or purchase action, all page elements, including the layout dropdown and settings metabox placeholders, should immediately reflect the updated state. For example, the dropdown should no longer show an "install" button for installed View types, and the settings metabox should display the correct status of installed or activated functionalities.

Actual Behavior:

The layout dropdown and settings metabox placeholders do not consistently update to reflect the latest state after performing installation, activation, or purchase actions. As a result, the page elements may show outdated information or incorrect statuses.

For example, the "View type" dropdown still shows the "Install" button for the View type that was just installed, even though the installation was successful.

Additional Info:

Related to #2110

@mrcasual
Copy link
Collaborator

@Mwalek, what about the settings metabox placeholders?

@Mwalek
Copy link
Author

Mwalek commented Aug 19, 2024

Thanks! Was not aware about that. Updating the issue ...

@Mwalek Mwalek changed the title View Type Dropdown Does Not Update After Layout Installation from Main Area State Not Updated Across Page Elements After Installation or Activation Aug 19, 2024
mrcasual added a commit that referenced this issue Oct 1, 2024
This PR addresses #2117 

After activating or installing a plugin, the selectors are updated; and
the settings block is re-rendered and replaced. This will ensure all the
new settings are available.

💾 [Build
file](https://www.dropbox.com/scl/fi/r845y7ujndgz7pjuztop9/gravityview-2.29-12afca1a4.zip?rlkey=iy270yx0yabawfamj6za0esvr&dl=1)
(12afca1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants