Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Plotter #329

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Conversation

vcatlett
Copy link
Collaborator

Interactive plotter PR... finally! This branch does not have very much documentation on it, but I'll add that next. Just want to get this into the main repo.

Note that I had to pin different versions of pyqt5-qt to get the dependencies to resolve.

vcatlett and others added 30 commits May 29, 2024 14:46
@vcatlett vcatlett marked this pull request as ready for review July 30, 2024 19:22
@vcatlett vcatlett requested review from mpound and astrofle July 30, 2024 19:22
@astrofle
Copy link
Collaborator

Something seems to be not working properly. I keep getting a "Kernel Restarting" message when trying to use Spectrum.plot():

Screenshot 2024-07-30 at 4 08 43 PM

I'm running dysh in RedHat (host thales).

I will try a fresh install directly from your fork.

If you're curious I'm running from this virtual env:
/home/sandboxes/psalas/Dysh/py3.9-venv

@mpound
Copy link
Collaborator

mpound commented Jul 30, 2024

Same here. Running positionswitch.ipynb. at the ta.plot() cell the kernel restarts.

@astrofle
Copy link
Collaborator

There are no plotter specific tests being run by pytest. The test file names should start with "test".

@vcatlett
Copy link
Collaborator Author

Good to know. I have 2 dev tests in a tests/ folder and will go ahead and finish them. I know what's causing the Jupyter crashes. I'd fixed it but must've removed the fix when I reverted back a bit to have a more complete version to publish.

@vcatlett vcatlett marked this pull request as draft August 14, 2024 15:55
@astrofle
Copy link
Collaborator

When running this through iPython I get an error when trying to follow the example:

from dysh.fits.gbtfitsload import GBTFITSLoad
filename = "/home/dysh/example_data/onoff-L/data/TGBT21A_501_11.raw.vegas.fits"

# Load data
sdfits = GBTFITSLoad(filename)
psscan = sdfits.getps(scan=152, ifnum=0, plnum=0)
ta = psscan.timeaverage(weights="tsys")

# Make sure .plot() works
ta.plot()

this raises the following error:

AttributeError: 'DyshMainWindow' object has no attribute 'xpos'

@vcatlett vcatlett marked this pull request as ready for review September 4, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants