Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new coils texture #1658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

new coils texture #1658

wants to merge 1 commit into from

Conversation

galyfray
Copy link
Contributor

@galyfray galyfray commented Jun 5, 2021

What:
Fixes: #1585
gonna be honest previous coils wasn't looking at all like coils

How solved:
created new textures inspired by the F32 patch

Outcome:
Fixes: #1585

Additional info:

here is a link to the base file I used to produce the coils. this is a gimp file and to create new coils simply choose use color>colorize on the layer with the coil inner texture choose your color and export . I put it here so addons creator can use it if they want or in case we would like to add new coils in the future. You may use the file as you want as long as you tell from were you took it.

@warjort
Copy link
Contributor

warjort commented Jun 5, 2021

Don't you think it looks weird with the background to the coils being a different color to the rest of the multiblock?

I think the reason why these textures were full blocks is because they can be used with MBs of different color.
e.g. the pyrolase oven or cracker unit.

If you want it to look more like a coil, perhaps you can do something like this?
https://ftb.fandom.com/wiki/Copper_Coil_Block

@galyfray
Copy link
Contributor Author

galyfray commented Jun 5, 2021

Don't you think it looks weird with the background to the coils being a different color to the rest of the multiblock?

no i don't I think this looks perfectly fine

@LAGIdiot
Copy link
Member

LAGIdiot commented Jun 6, 2021

How does this look on Pyrolysis oven?

@LAGIdiot LAGIdiot added subsystem: textures type: feature New feature or request rsr: revision Release size requirements: Revision labels Jun 6, 2021
@galyfray
Copy link
Contributor Author

galyfray commented Jun 6, 2021

it looks quite okay on pyrolyse oven and has the same problem than the older coils : we can't change the top orientation making it looking a bit weird.

@ALongStringOfNumbers
Copy link
Collaborator

Personally, I think that changing the coils like this should be done with a texturepack, especially since we are not likely to get a unified agreement on a new coil texture. These coils look, to me at least, pretty bad, but I am sure that other think that they look fine. There are several existing texture packs that change the looks of the coils, if how they currently look in GTCE does not look good (subjectively) to a player.

@galyfray
Copy link
Contributor Author

galyfray commented Jun 9, 2021

These coils look, to me at least, pretty bad, but I am sure that other think that they look fine.

yes I do. but can you explain why you dislike them ? I personally don't like how the top looks.

Personally, I think that changing the coils like this should be done with a texturepack, especially since we are not likely to get a unified agreement on a new coil texture.

So far the current coils texture are (I think most of the people will agree) pretty bad looking and have a different shadow than other blocks added by GTCE which is why I'm proposing this as a PR. The main idea of this PR is to discuss and propose textures that everyone would agree on :

  • it looks like a GTCE texture
  • it is better than the older texture

and I think it is possible that a large amount of people agree on both points.

@warjort
Copy link
Contributor

warjort commented Jun 9, 2021

Besides the issue I raised with the background texture color,
your texture also appears to have something of a Moire pattern.
https://en.wikipedia.org/wiki/Moir%C3%A9_pattern
at least in the top blast furnace image, my eyes want to interpret the coils as moving?

@ALongStringOfNumbers
Copy link
Collaborator

yes I do. but can you explain why you dislike them ? I personally don't like how the top looks.

I don't like the pastel shades of the colors that are used for the different coils, and I was never too fond of the diagonal stripe look present on the coils.
In addition, I do not like the metal seam running between the upper and lower coils on the ebf, instead I prefer the current coils which don't have the seam in the middle.

That last point might be something that is able to be addressed through CTM, although I am unsure if that would make CTM a hard dependency for GTCE.

Getting everyone to agree on a texture that satisfies everyone is a pretty hard thing to do, which is why I recommended this be solved by resourcepacks

@galyfray
Copy link
Contributor Author

galyfray commented Jun 9, 2021

at least in the top blast furnace image, my eyes want to interpret the coils as moving?
that's an interesting issue

I don't like the pastel shades of the colors that are used for the different coils, and I was never too fond of the diagonal stripe look present on the coils.

I tried to reuse has much as possible the original shade of the coils and colors looks really clone on my main monitor and not and my second I will try to find a way of fixing the colors

In addition, I do not like the metal seam running between the upper and lower coils on the ebf, instead I prefer the current coils which don't have the seam in the middle.

seems like you are not the only one disliking this ^^

I will work on new texture in grey scale to validate the pattern and then colorize them to validate the colors used.

@warjort
Copy link
Contributor

warjort commented Jun 9, 2021

That last point might be something that is able to be addressed through CTM, although I am unsure if that would make CTM a hard dependency for GTCE.

I am no expert, but I think CTM just requires adding a
block.pgn.mcmeta
to describe alternate CTM textures/metadata.

But I don't know if/how that works if you have custom rendering.

@TechLord22
Copy link
Contributor

These textures have numerous issues in my eyes. First of all, the textures are too "flat." The colors are very plain and don't blend well into each other. They also honestly just don't look very good, especially in comparison to the textures in other variants of GT (namely forks of GT5u).

I personally don't mind the metal bands running across the middle, but they are too jagged and also do not fit and blend well with the rest of the coil colors.

Furthermore, the coils do not vertically connect. The diagonals don't continue into the next when moving up or down a Y value, shown in this screenshot.
image

Frankly, I do not think GTCE needs any new textures for coils or really anything else, and I honestly think any and all coil retexturing should be left to resourcepacks.

In reply to @ALongStringOfNumbers: CTM textures would not make CTM a hard GTCE dependency, and are only optional png texture files used according to an MCMeta file, only loaded when CTM or Optifine is present. I have specifically done CTM work with coils for a resourcepack around a month ago. It is not very difficult, and is no different from using CTM with any other block.

@warjort
Copy link
Contributor

warjort commented Jun 9, 2021

Frankly, I do not think GTCE needs any new textures for coils or really anything else, and I honestly think any and all coil retexturing should be left to resourcepacks.

The issue I originally raised on the bug report is that the shadows are wrong in the current textures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rsr: revision Release size requirements: Revision subsystem: textures type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Shadows on Coil Blocks
5 participants