Fix phosphor ore names #1718
Merged
Fix phosphor ore names #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exaxxion
requested review from
LAGIdiot,
serenibyss and
ALongStringOfNumbers
ALongStringOfNumbers
approved these changes
Sep 20, 2021
Exaxxion
added
subsystem: internationalization/localization
type: bug
LAGIdiot
approved these changes
Oct 2, 2021
Exaxxion
added a commit
that referenced
this pull request
Dec 10, 2021
Corrects inadvertent rename to "Tricalcium Phospate" during the lang file adjustment in #1718
Exaxxion
referenced
this pull request
in Nomifactory/GregTech
Jan 26, 2022
Corrects inadvertent rename to "Tricalcium Phospate" during the lang file adjustment in #1718
Exaxxion
referenced
this pull request
in Nomifactory/GregTech
Jan 28, 2022
Corrects inadvertent rename to "Tricalcium Phospate" during the lang file adjustment in #1718
Exaxxion
referenced
this pull request
in Nomifactory/GregTech
Jan 28, 2022
Corrects inadvertent rename to "Tricalcium Phospate" during the lang file adjustment in #1718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
PR #1659 inadvertently swapped the localizations of the materials called Phosphor and Phosphate.
This PR corrects the mistake by applying the names to the correct materials. It also fixes a typo in the English localization of Phosphorus Pentoxide, which was incorrectly spelled "Phosphorous Pentoxide".
How solved:
Corrections made to the respective lang files.
Outcome:
Fixes #1566 by applying the names to the correct materials:
Possible compatibility issue:
None anticipated, though as I am not a native speaker of Russian or Chinese I cannot be entirely certain that those localizations are accurate.