Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting Multiblocks for Fission #2575

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Supporting Multiblocks for Fission #2575

wants to merge 8 commits into from

Conversation

bruberu
Copy link
Member

@bruberu bruberu commented Aug 7, 2024

This PR adds the gas centrifuge, spent fuel pool, and the heat exchanger, all of which are required for the nuclear update. It also makes minor changes to primitive recipe maps in order to get the heat exchanger to work correctly.

@bruberu bruberu requested a review from a team as a code owner August 7, 2024 23:41
@bruberu bruberu added the type: feature New feature or request label Aug 7, 2024
ALongStringOfNumbers
ALongStringOfNumbers requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@ALongStringOfNumbers ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing the json model definitions for the new blocks, causing errors to be sent to the log when this branch is ran.

Also missing entries into the lang file for the new blocks, including the multiblocks

src/main/java/gregtech/common/blocks/BlockPanelling.java Show resolved Hide resolved
src/main/java/gregtech/common/blocks/BlockGasCentrifugeCasing.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/metatileentities/multi/electric/MetaTileEntityGasCentrifuge.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/metatileentities/multi/electric/MetaTileEntityGasCentrifuge.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/metatileentities/multi/MetaTileEntitySpentFuelPool.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/metatileentities/multi/MetaTileEntitySpentFuelPool.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/metatileentities/multi/MetaTileEntitySpentFuelPool.java Outdated Show resolved Hide resolved
src/main/java/gregtech/common/metatileentities/MetaTileEntityHeatExchanger.java Show resolved Hide resolved
@TechLord22 TechLord22 added the status: do not merge PR should not be merged label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ALongStringOfNumbers ALongStringOfNumbers ALongStringOfNumbers approved these changes

Assignees
No one assigned
Labels
status: do not merge PR should not be merged type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruberu @ALongStringOfNumbers @TechLord22