Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: downgrade container to ubuntu 20.04 #108

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Oct 16, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR downgrades container version to Ubuntu 20.04

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review October 16, 2023 04:11
@evenyag evenyag marked this pull request as draft October 16, 2023 04:14
@evenyag evenyag marked this pull request as ready for review October 16, 2023 04:17
@MichaelScofield
Copy link
Collaborator

I understand the necessity of downgrade the building job of protobuf to ubuntu 20, it's related to some lib dependencies versions. But why other jobs?

@evenyag
Copy link
Contributor Author

evenyag commented Oct 17, 2023

I understand the necessity of downgrade the building job of protobuf to ubuntu 20, it's related to some lib dependencies versions. But why other jobs?

Just keep all jobs using the same OS version. Some jobs use the latest version, and some jobs use 20.04 is confusing.

@evenyag evenyag merged commit ced45cb into main Oct 18, 2023
16 checks passed
@evenyag evenyag deleted the ci/downgrade-container branch October 18, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants