Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace sink_table_id with sink_table_name #153

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 26, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

refactor: replace sink_table_id with sink_table_name

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu merged commit 2c14c6e into GreptimeTeam:main Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants