fix: fix github action to check untracked files #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinland-avalon
force-pushed
the
fix/github-action-check-untracked-files
branch
7 times, most recently
from
440bc9f
to
83f8aaa
Compare
vinland-avalon
force-pushed
the
fix/github-action-check-untracked-files
branch
from
83f8aaa
to
f86480c
Compare
vinland-avalon
force-pushed
the
fix/github-action-check-untracked-files
branch
from
a88d499
to
e0aa307
Compare
vinland-avalon
force-pushed
the
fix/github-action-check-untracked-files
branch
from
e0aa307
to
ef4f65a
Compare
vinland-avalon
force-pushed
the
fix/github-action-check-untracked-files
branch
from
ef4f65a
to
0f46f63
Compare
zyy17
reviewed
Mar 23, 2023
vinland-avalon
force-pushed
the
fix/github-action-check-untracked-files
branch
2 times, most recently
from
eba9545
to
111c1c9
Compare
vinland-avalon
force-pushed
the
fix/github-action-check-untracked-files
branch
from
111c1c9
to
0402fcd
Compare
|
@zyy17 After refactoring, I've tried it twice, one with wrong generated files, the other with right ones. And the github actions successfully checked them: the former failed and the latter succeed. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Fix github action to check untracked files.
The
git diff --exit-codecannot found difference of those untracked files. So I usedgit statusinstead.