Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename replay_timeout_secs to timeout_secs #191

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 10, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

add flush_timeout_secs to MigrateRegionRequest

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu force-pushed the feat/migration-with-flush-timeout branch from f440e84 to 3633474 Compare September 20, 2024 07:04
@WenyXu WenyXu changed the title feat: add flush_timeout_secs to MigrateRegionRequest feat: rename replay_timeout_secs to timeout_secs Sep 20, 2024
@WenyXu WenyXu force-pushed the feat/migration-with-flush-timeout branch from c574bed to a86def4 Compare September 27, 2024 03:05
@WenyXu WenyXu force-pushed the feat/migration-with-flush-timeout branch from a86def4 to 0b4f7c8 Compare September 27, 2024 03:38
@v0y4g3r v0y4g3r self-requested a review October 17, 2024 05:13
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit b4d3011 into GreptimeTeam:main Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants