Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cpp grpc CMakeLists.txt #66

Merged
merged 2 commits into from
Jul 15, 2023

Conversation

Nateiru
Copy link
Contributor

@Nateiru Nateiru commented Jul 14, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

The cpp codes generated by proto need to add CMakeLists.txt in the corresponding directory

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@Nateiru Nateiru self-assigned this Jul 14, 2023
@Nateiru Nateiru requested review from v0y4g3r and WenyXu July 14, 2023 10:34
c++/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 9b23f28 into GreptimeTeam:main Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants