Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define region server related messages #79

Merged
merged 9 commits into from
Aug 15, 2023
Merged

feat: define region server related messages #79

merged 9 commits into from
Aug 15, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

define a new service for datanode (region server). Compared to the existing GreptimeDatabase, the new RegionServer is considered internal.

The planned usage of this service is to handle all requests to region, except the query request, which will be handled in flight.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia requested a review from evenyag August 15, 2023 08:35
proto/greptime/v1/region/server.proto Outdated Show resolved Hide resolved
proto/greptime/v1/region/server.proto Outdated Show resolved Hide resolved
@waynexia waynexia requested a review from evenyag August 15, 2023 09:15
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia merged commit dbb8e52 into main Aug 15, 2023
6 checks passed
@waynexia waynexia deleted the region branch August 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants