feat: v04 new heartbeat #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelScofield
approved these changes
Aug 31, 2023
2 tasks
WenyXu
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Due to the historical level incompatible upgrade of 0.4 region server, some changes also need to be made in the Heartbeat section accordingly. This PR mainly includes the following modifications:
NodeStatbecause the corresponding data can be calculated based on allRegionStats. We should keep the heartbeat packets as compact as possible and reduce redundant information.attrssince it seems to be of no useTableIdentwithRegionId, and note that we are now dealing with region server(datanode), so it's best not to focus on table information.Checklist
Refer to a related PR or issue link (optional)