fix: sqlness

src/catalog/src/lib.rs

@@ -29,7 +29,6 @@ use table::TableRef;
 use crate::error::{CreateTableSnafu, Result};
 pub use crate::schema::{SchemaProvider, SchemaProviderRef};
 
-pub mod datafusion;
 pub mod error;
 pub mod helper;
 pub(crate) mod information_schema;

src/catalog/src/remote/manager.rs

@@ -664,7 +664,7 @@ impl CatalogProvider for RemoteCatalogProvider {
         let res = remote_schemas
             .map(|kv| {
                 let Kv(k, _) = kv?;
-                let schema_key = SchemaKey::parse(&String::from_utf8_lossy(&k))
+                let schema_key = SchemaKey::parse(String::from_utf8_lossy(&k))
                     .context(InvalidCatalogValueSnafu)?;
                 Ok(schema_key.schema_name)
             })
@@ -749,7 +749,7 @@ impl SchemaProvider for RemoteSchemaProvider {
         let table_names = iter
             .map(|kv| {
                 let Kv(key, _) = kv?;
-                let regional_key = TableRegionalKey::parse(&String::from_utf8_lossy(&key))
+                let regional_key = TableRegionalKey::parse(String::from_utf8_lossy(&key))
                     .context(InvalidCatalogValueSnafu)?;
                 Ok(regional_key.table_name)
             })
@@ -769,7 +769,7 @@ impl SchemaProvider for RemoteSchemaProvider {
                     // TODO(hl): we should put engine info in table regional value
                     // so that here we can use correct engine name
                     let TableRegionalValue { .. } =
-                        TableRegionalValue::parse(&String::from_utf8_lossy(&v))
+                        TableRegionalValue::parse(String::from_utf8_lossy(&v))
                             .context(InvalidCatalogValueSnafu)?;
 
                     let reference = TableReference {

src/frontend/src/catalog.rs

@@ -272,8 +272,7 @@ impl CatalogManager for FrontendCatalogManager {
                 .context(catalog::error::CatalogNotFoundSnafu {
                     catalog_name: catalog,
                 })?;
-        let result = catalog.schema(schema).await;
-        result
+        catalog.schema(schema).await
     }
 
     async fn table(

src/table/src/metadata.rs

@@ -177,6 +177,7 @@ impl TableMeta {
                 meta_builder
                     .schema(self.schema.clone())
                     .primary_key_indices(self.primary_key_indices.clone())
+                    .engine(self.engine.clone())
                     .next_column_id(self.next_column_id);
                 Ok(meta_builder)
             }

tests/cases/distributed/alter/rename_table.result

@@ -27,9 +27,17 @@ SELECT * from t;
 
 ALTER TABLE t RENAME new_table;
 
-Error: 1003(Internal), Operation rename table not implemented yet
+Affected Rows: 0
+
+DESC TABLE t;
+
+Error: 4001(TableNotFound), Table `t` not exist
 
 DROP TABLE t;
 
-Affected Rows: 1
+Error: 4001(TableNotFound), Table `greptime.public.t` not exist
+
+DROP TABLE new_table;
+
+Error: 1003(Internal), status: Internal, message: "Table route not found: __meta_table_route-greptime-public-new_table-1025", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Tue, 25 Apr 2023 08:16:06 GMT", "content-length": "0"} }
 

tests/cases/distributed/alter/rename_table.sql

@@ -9,4 +9,9 @@ SELECT * from t;
 -- TODO(LFC): Port test cases from standalone env when distribute rename table is implemented (#723).
 ALTER TABLE t RENAME new_table;
 
+DESC TABLE t;
+
 DROP TABLE t;
+
+-- This will fail since we don't alter table routes when renaming table https://github.com/GreptimeTeam/greptimedb/issues/1464
+DROP TABLE new_table;