chore: replace result assertions (#1840)

* s/assert!\((.*)\.is_ok\(\)\);/\1.unwrap\(\);/g

* s/assert!\((.*)\.is_some\(\)\);/\1.unwrap\(\);/g

src/catalog/src/helper.rs

@@ -392,6 +392,6 @@ mod tests {
     #[test]
     fn test_table_global_value_compatibility() {
         let s = r#"{"node_id":1,"regions_id_map":{"1":[0]},"table_info":{"ident":{"table_id":1098,"version":1},"name":"container_cpu_limit","desc":"Created on insertion","catalog_name":"greptime","schema_name":"dd","meta":{"schema":{"column_schemas":[{"name":"container_id","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"container_name","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"docker_image","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"host","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"image_name","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"image_tag","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"interval","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"runtime","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"short_image","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"type","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"dd_value","data_type":{"Float64":{}},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}},{"name":"ts","data_type":{"Timestamp":{"Millisecond":null}},"is_nullable":false,"is_time_index":true,"default_constraint":null,"metadata":{"greptime:time_index":"true"}},{"name":"git.repository_url","data_type":{"String":null},"is_nullable":true,"is_time_index":false,"default_constraint":null,"metadata":{}}],"timestamp_index":11,"version":1},"primary_key_indices":[0,1,2,3,4,5,6,7,8,9,12],"value_indices":[10,11],"engine":"mito","next_column_id":12,"region_numbers":[],"engine_options":{},"options":{},"created_on":"1970-01-01T00:00:00Z"},"table_type":"Base"}}"#;
-        assert!(TableGlobalValue::parse(s).is_ok());
+        let _ = TableGlobalValue::parse(s).unwrap();
     }
 }

src/catalog/src/local/memory.rs

@@ -344,7 +344,7 @@ mod tests {
             table: Arc::new(NumbersTable::default()),
         };
 
-        assert!(catalog_list.register_table(register_request).await.is_ok());
+        let _ = catalog_list.register_table(register_request).await.unwrap();
         let table = catalog_list
             .table(
                 DEFAULT_CATALOG_NAME,
@@ -353,7 +353,7 @@ mod tests {
             )
             .await
             .unwrap();
-        assert!(table.is_some());
+        let _ = table.unwrap();
         assert!(catalog_list
             .table(DEFAULT_CATALOG_NAME, DEFAULT_SCHEMA_NAME, "not_exists")
             .await
@@ -393,7 +393,7 @@ mod tests {
             new_table_name: new_table_name.to_string(),
             table_id,
         };
-        assert!(catalog.rename_table(rename_request).await.is_ok());
+        let _ = catalog.rename_table(rename_request).await.unwrap();
 
         // test old table name not exist
         assert!(!catalog
@@ -495,7 +495,7 @@ mod tests {
             table_id: 2333,
             table: Arc::new(NumbersTable::default()),
         };
-        assert!(catalog.register_table(register_table_req).await.is_ok());
+        let _ = catalog.register_table(register_table_req).await.unwrap();
         assert!(catalog
             .table(DEFAULT_CATALOG_NAME, DEFAULT_SCHEMA_NAME, table_name)
             .await

src/catalog/src/remote/region_alive_keeper.rs

@@ -677,7 +677,7 @@ mod test {
         let region = 1;
         assert!(keeper.find_handle(&region).await.is_none());
         keeper.register_region(region).await;
-        assert!(keeper.find_handle(&region).await.is_some());
+        let _ = keeper.find_handle(&region).await.unwrap();
 
         let ten_seconds_later = || Instant::now() + Duration::from_secs(10);
 
@@ -720,7 +720,7 @@ mod test {
         let tx = handle.tx.clone();
 
         // assert countdown task is running
-        assert!(tx.send(CountdownCommand::Start(5000)).await.is_ok());
+        tx.send(CountdownCommand::Start(5000)).await.unwrap();
         assert!(!finished.load(Ordering::Relaxed));
 
         drop(handle);
@@ -772,7 +772,7 @@ mod test {
         };
 
         let table_engine = Arc::new(MockTableEngine::default());
-        assert!(table_engine.create_table(ctx, request).await.is_ok());
+        let _ = table_engine.create_table(ctx, request).await.unwrap();
 
         let table_ident = TableIdent {
             catalog: catalog.to_string(),

src/catalog/src/table_source.rs

@@ -136,14 +136,14 @@ mod tests {
             table: Cow::Borrowed("table_name"),
         };
         let result = table_provider.resolve_table_ref(table_ref);
-        assert!(result.is_ok());
+        let _ = result.unwrap();
 
         let table_ref = TableReference::Partial {
             schema: Cow::Borrowed("public"),
             table: Cow::Borrowed("table_name"),
         };
         let result = table_provider.resolve_table_ref(table_ref);
-        assert!(result.is_ok());
+        let _ = result.unwrap();
 
         let table_ref = TableReference::Partial {
             schema: Cow::Borrowed("wrong_schema"),
@@ -158,7 +158,7 @@ mod tests {
             table: Cow::Borrowed("table_name"),
         };
         let result = table_provider.resolve_table_ref(table_ref);
-        assert!(result.is_ok());
+        let _ = result.unwrap();
 
         let table_ref = TableReference::Full {
             catalog: Cow::Borrowed("wrong_catalog"),
@@ -172,14 +172,14 @@ mod tests {
             schema: Cow::Borrowed("information_schema"),
             table: Cow::Borrowed("columns"),
         };
-        assert!(table_provider.resolve_table_ref(table_ref).is_ok());
+        let _ = table_provider.resolve_table_ref(table_ref).unwrap();
 
         let table_ref = TableReference::Full {
             catalog: Cow::Borrowed("greptime"),
             schema: Cow::Borrowed("information_schema"),
             table: Cow::Borrowed("columns"),
         };
-        assert!(table_provider.resolve_table_ref(table_ref).is_ok());
+        let _ = table_provider.resolve_table_ref(table_ref).unwrap();
 
         let table_ref = TableReference::Full {
             catalog: Cow::Borrowed("dummy"),

src/catalog/tests/remote_catalog_tests.rs

@@ -109,7 +109,7 @@ mod tests {
             .unwrap();
 
         let ret = backend.get(b"__c-greptime").await.unwrap();
-        assert!(ret.is_some());
+        let _ = ret.unwrap();
 
         let _ = backend
             .compare_and_set(
@@ -121,13 +121,11 @@ mod tests {
             .unwrap();
 
         let ret = backend.get(b"__c-greptime").await.unwrap();
-        assert!(ret.is_some());
         assert_eq!(&b"123"[..], &(ret.as_ref().unwrap().1));
 
         let _ = backend.set(b"__c-greptime", b"1234").await;
 
         let ret = backend.get(b"__c-greptime").await.unwrap();
-        assert!(ret.is_some());
         assert_eq!(&b"1234"[..], &(ret.as_ref().unwrap().1));
 
         backend.delete(b"__c-greptime").await.unwrap();

src/cmd/src/frontend.rs

@@ -339,19 +339,15 @@ mod tests {
         };
 
         let plugins = load_frontend_plugins(&command.user_provider);
-        assert!(plugins.is_ok());
         let plugins = plugins.unwrap();
-        let provider = plugins.get::<UserProviderRef>();
-        assert!(provider.is_some());
-
-        let provider = provider.unwrap();
+        let provider = plugins.get::<UserProviderRef>().unwrap();
         let result = provider
             .authenticate(
                 Identity::UserId("test", None),
                 Password::PlainText("test".to_string().into()),
             )
             .await;
-        assert!(result.is_ok());
+        let _ = result.unwrap();
     }
 
     #[test]

src/cmd/src/standalone.rs

@@ -356,18 +356,15 @@ mod tests {
         };
 
         let plugins = load_frontend_plugins(&command.user_provider);
-        assert!(plugins.is_ok());
         let plugins = plugins.unwrap();
-        let provider = plugins.get::<UserProviderRef>();
-        assert!(provider.is_some());
-        let provider = provider.unwrap();
+        let provider = plugins.get::<UserProviderRef>().unwrap();
         let result = provider
             .authenticate(
                 Identity::UserId("test", None),
                 Password::PlainText("test".to_string().into()),
             )
             .await;
-        assert!(result.is_ok());
+        let _ = result.unwrap();
     }
 
     #[test]

src/cmd/tests/cli.rs

@@ -27,7 +27,7 @@ mod tests {
 
     impl Repl {
         fn send_line(&mut self, line: &str) {
-            assert!(self.repl.send_line(line).is_ok());
+            let _ = self.repl.send_line(line).unwrap();
 
             // read a line to consume the prompt
             let _ = self.read_line();
@@ -105,7 +105,7 @@ mod tests {
         test_select(repl);
 
         datanode.kill().unwrap();
-        assert!(datanode.wait().is_ok());
+        let _ = datanode.wait().unwrap();
     }
 
     fn test_create_database(repl: &mut Repl) {

src/common/base/tests/buffer_tests.rs

@@ -119,7 +119,7 @@ mod tests {
                     #[test]
                     fn [<test_read_write_ $num_ty _from_vec_buffer>]() {
                         let mut buf = vec![];
-                        assert!(buf.[<write_ $num_ty _le>]($num_ty::MAX).is_ok());
+                        let _ = buf.[<write_ $num_ty _le>]($num_ty::MAX).unwrap();
                         assert_eq!($num_ty::MAX, buf.as_slice().[<read_ $num_ty _le>]().unwrap());
                     }
                 }
@@ -132,7 +132,7 @@ mod tests {
     #[test]
     pub fn test_peek_write_from_vec_buffer() {
         let mut buf: Vec<u8> = vec![];
-        assert!(buf.write_from_slice("hello".as_bytes()).is_ok());
+        buf.write_from_slice("hello".as_bytes()).unwrap();
         let mut slice = buf.as_slice();
         assert_eq!(104, slice.peek_u8_le().unwrap());
         slice.advance_by(1);

src/common/function/src/scalars/aggregate/argmax.rs

@@ -158,19 +158,19 @@ mod test {
     fn test_update_batch() {
         // test update empty batch, expect not updating anything
         let mut argmax = Argmax::<i32>::default();
-        assert!(argmax.update_batch(&[]).is_ok());
+        argmax.update_batch(&[]).unwrap();
         assert_eq!(Value::Null, argmax.evaluate().unwrap());
 
         // test update one not-null value
         let mut argmax = Argmax::<i32>::default();
         let v: Vec<VectorRef> = vec![Arc::new(Int32Vector::from(vec![Some(42)]))];
-        assert!(argmax.update_batch(&v).is_ok());
+        argmax.update_batch(&v).unwrap();
         assert_eq!(Value::from(0_u64), argmax.evaluate().unwrap());
 
         // test update one null value
         let mut argmax = Argmax::<i32>::default();
         let v: Vec<VectorRef> = vec![Arc::new(Int32Vector::from(vec![Option::<i32>::None]))];
-        assert!(argmax.update_batch(&v).is_ok());
+        argmax.update_batch(&v).unwrap();
         assert_eq!(Value::Null, argmax.evaluate().unwrap());
 
         // test update no null-value batch
@@ -180,7 +180,7 @@ mod test {
             Some(1),
             Some(3),
         ]))];
-        assert!(argmax.update_batch(&v).is_ok());
+        argmax.update_batch(&v).unwrap();
         assert_eq!(Value::from(2_u64), argmax.evaluate().unwrap());
 
         // test update null-value batch
@@ -190,7 +190,7 @@ mod test {
             None,
             Some(4),
         ]))];
-        assert!(argmax.update_batch(&v).is_ok());
+        argmax.update_batch(&v).unwrap();
         assert_eq!(Value::from(2_u64), argmax.evaluate().unwrap());
 
         // test update with constant vector
@@ -199,7 +199,7 @@ mod test {
             Arc::new(Int32Vector::from_vec(vec![4])),
             10,
         ))];
-        assert!(argmax.update_batch(&v).is_ok());
+        argmax.update_batch(&v).unwrap();
         assert_eq!(Value::from(0_u64), argmax.evaluate().unwrap());
     }
 }

src/common/function/src/scalars/aggregate/argmin.rs

@@ -166,19 +166,19 @@ mod test {
     fn test_update_batch() {
         // test update empty batch, expect not updating anything
         let mut argmin = Argmin::<i32>::default();
-        assert!(argmin.update_batch(&[]).is_ok());
+        argmin.update_batch(&[]).unwrap();
         assert_eq!(Value::Null, argmin.evaluate().unwrap());
 
         // test update one not-null value
         let mut argmin = Argmin::<i32>::default();
         let v: Vec<VectorRef> = vec![Arc::new(Int32Vector::from(vec![Some(42)]))];
-        assert!(argmin.update_batch(&v).is_ok());
+        argmin.update_batch(&v).unwrap();
         assert_eq!(Value::from(0_u32), argmin.evaluate().unwrap());
 
         // test update one null value
         let mut argmin = Argmin::<i32>::default();
         let v: Vec<VectorRef> = vec![Arc::new(Int32Vector::from(vec![Option::<i32>::None]))];
-        assert!(argmin.update_batch(&v).is_ok());
+        argmin.update_batch(&v).unwrap();
         assert_eq!(Value::Null, argmin.evaluate().unwrap());
 
         // test update no null-value batch
@@ -188,7 +188,7 @@ mod test {
             Some(1),
             Some(3),
         ]))];
-        assert!(argmin.update_batch(&v).is_ok());
+        argmin.update_batch(&v).unwrap();
         assert_eq!(Value::from(0_u32), argmin.evaluate().unwrap());
 
         // test update null-value batch
@@ -198,7 +198,7 @@ mod test {
             None,
             Some(4),
         ]))];
-        assert!(argmin.update_batch(&v).is_ok());
+        argmin.update_batch(&v).unwrap();
         assert_eq!(Value::from(0_u32), argmin.evaluate().unwrap());
 
         // test update with constant vector
@@ -207,7 +207,7 @@ mod test {
             Arc::new(Int32Vector::from_vec(vec![4])),
             10,
         ))];
-        assert!(argmin.update_batch(&v).is_ok());
+        argmin.update_batch(&v).unwrap();
         assert_eq!(Value::from(0_u32), argmin.evaluate().unwrap());
     }
 }

src/common/function/src/scalars/aggregate/diff.rs

@@ -192,20 +192,20 @@ mod test {
     fn test_update_batch() {
         // test update empty batch, expect not updating anything
         let mut diff = Diff::<i32, i64>::default();
-        assert!(diff.update_batch(&[]).is_ok());
+        diff.update_batch(&[]).unwrap();
         assert!(diff.values.is_empty());
         assert_eq!(Value::Null, diff.evaluate().unwrap());
 
         // test update one not-null value
         let mut diff = Diff::<i32, i64>::default();
         let v: Vec<VectorRef> = vec![Arc::new(Int32Vector::from(vec![Some(42)]))];
-        assert!(diff.update_batch(&v).is_ok());
+        diff.update_batch(&v).unwrap();
         assert_eq!(Value::Null, diff.evaluate().unwrap());
 
         // test update one null value
         let mut diff = Diff::<i32, i64>::default();
         let v: Vec<VectorRef> = vec![Arc::new(Int32Vector::from(vec![Option::<i32>::None]))];
-        assert!(diff.update_batch(&v).is_ok());
+        diff.update_batch(&v).unwrap();
         assert_eq!(Value::Null, diff.evaluate().unwrap());
 
         // test update no null-value batch
@@ -216,7 +216,7 @@ mod test {
             Some(2),
         ]))];
         let values = vec![Value::from(2_i64), Value::from(1_i64)];
-        assert!(diff.update_batch(&v).is_ok());
+        diff.update_batch(&v).unwrap();
         assert_eq!(
             Value::List(ListValue::new(
                 Some(Box::new(values)),
@@ -234,7 +234,7 @@ mod test {
             Some(4),
         ]))];
         let values = vec![Value::from(5_i64), Value::from(1_i64)];
-        assert!(diff.update_batch(&v).is_ok());
+        diff.update_batch(&v).unwrap();
         assert_eq!(
             Value::List(ListValue::new(
                 Some(Box::new(values)),
@@ -250,7 +250,7 @@ mod test {
             4,
         ))];
         let values = vec![Value::from(0_i64), Value::from(0_i64), Value::from(0_i64)];
-        assert!(diff.update_batch(&v).is_ok());
+        diff.update_batch(&v).unwrap();
         assert_eq!(
             Value::List(ListValue::new(
                 Some(Box::new(values)),