feat: set max log files to 720 by default, info log only #4787

Kev1n8 · 2024-09-30T04:48:47Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Closes #4777.

What's changed and what's your intention?

Exposed max_log_files in LoggingOptions, set it to 720 by default, and build info_log with this restriction.

Checklist

Not sure how to test this. It passed CI tho.

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.

coderabbitai · 2024-09-30T04:48:54Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

src/common/telemetry/src/logging.rs

… and that of slow_queries to opt.max_log_files

v0y4g3r · 2024-09-30T22:25:57Z

@Kev1n8 Looks like some CI checks failed, please run those checks locally to ensure CI can pass:

# Check code style
cargo clippy --workspace --all-targets -- -D warnings
# Check if doc is up-to-date
make config-docs
# Run all unit tests
cargo test --workspace --all-targets

The failure in unit test relates to your changes in configuration file.

Kev1n8 · 2024-10-01T05:17:57Z

Seems like there's still something wrong. I'll look into it. Any suggestions will be hugely appreciated too!

v0y4g3r · 2024-10-01T19:38:10Z

@Kev1n8 Looks like there're some typos detected (though those files are not touched in this PR). Cloud you please also fix them?

codecov · 2024-10-01T19:51:52Z

Codecov Report

Attention: Patch coverage is 45.71429% with 19 lines in your changes missing coverage. Please review.

Project coverage is 84.20%. Comparing base (e39a9e6) to head (cbcacd2).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4787      +/-   ##
==========================================
- Coverage   84.45%   84.20%   -0.25%     
==========================================
  Files        1120     1120              
  Lines      203478   204139     +661     
==========================================
+ Hits       171841   171898      +57     
- Misses      31637    32241     +604

killme2008 · 2024-10-02T02:15:34Z

@Kev1n8 Looks like there are some typos in checking https://github.com/GreptimeTeam/greptimedb/actions/runs/11120980442/job/30935597697?pr=4787

It's not related to this PR, but would you like to fix them in this PR too? Thanks a lot.

killme2008

Almost LGTM

src/common/telemetry/src/logging.rs

Kev1n8 · 2024-10-03T16:29:57Z

@Kev1n8 Looks like there are some typos in checking https://github.com/GreptimeTeam/greptimedb/actions/runs/11120980442/job/30935597697?pr=4787

It's not related to this PR, but would you like to fix them in this PR too? Thanks a lot.

Sure.

… when panicing, put `max_l_f` in right position

v0y4g3r

@Kev1n8 Looks like config api test still fails.

tests-integration/tests/http.rs

Co-authored-by: Lei, HUANG <[email protected]>

Kev1n8 · 2024-10-04T06:25:09Z

@Kev1n8 Looks like config api test still fails.

My bad. Thanks for fixing that!

feat: set max log files to 720 by default, info log only

6cff452

Kev1n8 requested a review from a team as a code owner September 30, 2024 04:48

github-actions bot added the docs-not-required This change does not impact docs. label Sep 30, 2024

v0y4g3r reviewed Sep 30, 2024

View reviewed changes

src/common/telemetry/src/logging.rs Outdated Show resolved Hide resolved

src/common/telemetry/src/logging.rs Outdated Show resolved Hide resolved

v0y4g3r requested a review from evenyag September 30, 2024 06:44

evenyag reviewed Sep 30, 2024

View reviewed changes

src/common/telemetry/src/logging.rs Show resolved Hide resolved

Kev1n8 added 2 commits September 30, 2024 16:51

expose max_log_files in tomls

6bb4255

include dir info when panicing, limit max_log_files of err_log to 30,…

9b62417

… and that of slow_queries to opt.max_log_files

Kev1n8 added 2 commits October 1, 2024 10:29

fix clippy

ede3025

update config.md

2dbdb26

v0y4g3r requested a review from evenyag October 1, 2024 03:59

update expected config str

60339bf

killme2008 approved these changes Oct 2, 2024

View reviewed changes

src/common/telemetry/src/logging.rs Outdated Show resolved Hide resolved

evenyag reviewed Oct 2, 2024

View reviewed changes

src/common/telemetry/src/logging.rs Outdated Show resolved Hide resolved

src/common/telemetry/src/logging.rs Outdated Show resolved Hide resolved

src/common/telemetry/src/logging.rs Outdated Show resolved Hide resolved

src/common/telemetry/src/logging.rs Outdated Show resolved Hide resolved

Kev1n8 added 2 commits October 4, 2024 00:54

limit err_log max files size to max_log_files too, include err info…

2833933

… when panicing, put `max_l_f` in right position

fix typos

59d4f6c

v0y4g3r enabled auto-merge October 3, 2024 19:58

v0y4g3r self-requested a review October 3, 2024 19:59

v0y4g3r approved these changes Oct 3, 2024

View reviewed changes

v0y4g3r reviewed Oct 4, 2024

View reviewed changes

tests-integration/tests/http.rs Outdated Show resolved Hide resolved

chore: config

cbcacd2

Co-authored-by: Lei, HUANG <[email protected]>

v0y4g3r added this pull request to the merge queue Oct 4, 2024

Merged via the queue into GreptimeTeam:main with commit a283e13 Oct 4, 2024
41 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: set max log files to 720 by default, info log only #4787

feat: set max log files to 720 by default, info log only #4787

Kev1n8 commented Sep 30, 2024

coderabbitai bot commented Sep 30, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

v0y4g3r commented Sep 30, 2024 •

edited

Loading

Kev1n8 commented Oct 1, 2024

v0y4g3r commented Oct 1, 2024 •

edited

Loading

codecov bot commented Oct 1, 2024 •

edited

Loading

killme2008 commented Oct 2, 2024

killme2008 left a comment

Kev1n8 commented Oct 3, 2024

v0y4g3r left a comment •

edited

Loading

Kev1n8 commented Oct 4, 2024

feat: set max log files to 720 by default, info log only #4787

feat: set max log files to 720 by default, info log only #4787

Conversation

Kev1n8 commented Sep 30, 2024

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

coderabbitai bot commented Sep 30, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

v0y4g3r commented Sep 30, 2024 • edited Loading

Kev1n8 commented Oct 1, 2024

v0y4g3r commented Oct 1, 2024 • edited Loading

codecov bot commented Oct 1, 2024 • edited Loading

Codecov Report

killme2008 commented Oct 2, 2024

killme2008 left a comment

Choose a reason for hiding this comment

Kev1n8 commented Oct 3, 2024

v0y4g3r left a comment • edited Loading

Choose a reason for hiding this comment

Kev1n8 commented Oct 4, 2024

v0y4g3r commented Sep 30, 2024 •

edited

Loading

v0y4g3r commented Oct 1, 2024 •

edited

Loading

codecov bot commented Oct 1, 2024 •

edited

Loading

v0y4g3r left a comment •

edited

Loading