Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set max log files to 720 by default, info log only #4787

Merged
merged 9 commits into from
Oct 4, 2024
Merged

feat: set max log files to 720 by default, info log only #4787

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6cff452
feat: set max log files to 720 by default, info log only
Kev1n8 Sep 30, 2024
6bb4255
expose max_log_files in tomls
Kev1n8 Sep 30, 2024
9b62417
include dir info when panicing, limit max_log_files of err_log to 30,…
Kev1n8 Sep 30, 2024
ede3025
fix clippy
Kev1n8 Oct 1, 2024
2dbdb26
update config.md
Kev1n8 Oct 1, 2024
60339bf
update expected config str
Kev1n8 Oct 1, 2024
2833933
limit err_log max files size to `max_log_files` too, include err info…
Kev1n8 Oct 3, 2024
59d4f6c
fix typos
Kev1n8 Oct 3, 2024
cbcacd2
chore: config
killme2008 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/common/telemetry/src/logging.rs
View file
Open in desktop
Kev1n8 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ pub struct LoggingOptions {

/// The logging options of slow query.
pub slow_query: SlowQueryOptions,

/// The maximum number of log files set by default.
pub max_log_files: usize,
Kev1n8 marked this conversation as resolved.
Show resolved Hide resolved
Kev1n8 marked this conversation as resolved.
Show resolved Hide resolved
}

/// The options of slow query.
Expand Down Expand Up @@ -116,6 +119,8 @@ impl Default for LoggingOptions {
tracing_sample_ratio: None,
append_stdout: true,
slow_query: SlowQueryOptions::default(),
// Rotation hourly, 24 files per day, keeps info log files of 30 days
max_log_files: 720,
}
}
}
Expand Down Expand Up @@ -206,8 +211,12 @@ pub fn init_global_logging(

// Configure the file logging layer with rolling policy.
let file_logging_layer = if !opts.dir.is_empty() {
let rolling_appender =
RollingFileAppender::new(Rotation::HOURLY, &opts.dir, "greptimedb");
let rolling_appender = RollingFileAppender::builder()
.rotation(Rotation::HOURLY)
.filename_prefix("greptimedb")
.max_log_files(opts.max_log_files)
.build(&opts.dir)
.expect("initializing rolling file appender failed");
v0y4g3r marked this conversation as resolved.
Show resolved Hide resolved
let (writer, guard) = tracing_appender::non_blocking(rolling_appender);
guards.push(guard);

Expand Down
Loading