-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve Prometheus compliance #1022
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1022 +/- ##
===========================================
- Coverage 86.23% 85.82% -0.41%
===========================================
Files 436 441 +5
Lines 63279 64376 +1097
===========================================
+ Hits 54568 55251 +683
- Misses 8711 9125 +414
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
filter out NaN in normalize remove NULL in instant manipulator accept form data as HTTP params correct API URL accept second literal as step param
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
* initial impl Signed-off-by: Ruihang Xia <[email protected]> * minor (useless) refactor Signed-off-by: Ruihang Xia <[email protected]> * retrieve metric name Signed-off-by: Ruihang Xia <[email protected]> * add time index column to group by columns filter out NaN in normalize remove NULL in instant manipulator accept form data as HTTP params correct API URL accept second literal as step param * happy clippy Signed-off-by: Ruihang Xia <[email protected]> * update test result Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
(Our metadata are dropped during query execution. We can only infer semantic type from the data type.)
v1/range_query
toapi/v1/query_range
5
)Checklist
Refer to a related PR or issue link (optional)
Closes #1020