Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support filter expression in PromQL #1066

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

support filter expression like some_metric > 1.2345 in PromQL.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#1042

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1066 (1704168) into develop (2df8143) will increase coverage by 0.03%.
The diff coverage is 91.22%.

@@             Coverage Diff             @@
##           develop    #1066      +/-   ##
===========================================
+ Coverage    85.70%   85.73%   +0.03%     
===========================================
  Files          450      450              
  Lines        65736    65789      +53     
===========================================
+ Hits         56338    56407      +69     
+ Misses        9398     9382      -16     
Flag Coverage Δ
rust 85.73% <91.22%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/promql/src/planner.rs 88.53% <91.22%> (+0.25%) ⬆️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 43.77% <0.00%> (-14.34%) ⬇️
tests-integration/src/test_util.rs 79.16% <0.00%> (-9.47%) ⬇️
src/frontend/src/table/scan.rs 85.18% <0.00%> (-5.56%) ⬇️
src/servers/src/auth/user_provider.rs 81.81% <0.00%> (-2.28%) ⬇️
src/common/substrait/src/df_logical.rs 77.02% <0.00%> (-0.88%) ⬇️
src/servers/src/mysql/handler.rs 67.40% <0.00%> (-0.75%) ⬇️
src/servers/src/postgres/handler.rs 78.59% <0.00%> (-0.19%) ⬇️
src/table/src/requests.rs 85.43% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanbohan yuanbohan merged commit 51641db into GreptimeTeam:develop Feb 23, 2023
@waynexia waynexia deleted the binary-filter branch February 23, 2023 04:06
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
feat: support filter expression

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants