Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resets): add initial implementation #1306

Merged
merged 1 commit into from
Apr 3, 2023
Merged

feat(resets): add initial implementation #1306

merged 1 commit into from
Apr 3, 2023

Conversation

etolbakov
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Implement the changes function resets from PromQL(references to promql's document and the go implementation for more details.)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link

#1225

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #1306 (4d56479) into develop (48c2841) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1306      +/-   ##
===========================================
- Coverage    85.76%   85.36%   -0.40%     
===========================================
  Files          502      503       +1     
  Lines        76130    76191      +61     
===========================================
- Hits         65294    65044     -250     
- Misses       10836    11147     +311     

@etolbakov
Copy link
Collaborator Author

Hi @waynexia
Could you please take a look when you have time?

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! The tests are very concrete 👍

@MichaelScofield MichaelScofield merged commit 5848f27 into GreptimeTeam:develop Apr 3, 2023
@etolbakov etolbakov deleted the feat/resets-promql branch April 3, 2023 06:03
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants