feat: implement predict_linear function in promql #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1362 +/- ##
===========================================
- Coverage 86.04% 85.68% -0.36%
===========================================
Files 523 531 +8
Lines 78396 79235 +839
===========================================
+ Hits 67454 67895 +441
- Misses 10942 11340 +398 |
waynexia
reviewed
Apr 11, 2023
There was a problem hiding this comment.
Thanks for this. And sorry that I forget to mention, except for implementing the PredictLinear struct, you also need to initialize it in the planner. This part in holt_winters can be a good reference
sunng87
reviewed
Apr 13, 2023
waynexia
approved these changes
Apr 13, 2023
sunng87
approved these changes
Apr 14, 2023
|
Thanks @haohuaijin, and @sunng87 for reviewing |
35 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: implement predict_linear function in promql * feat: initialize predict_linear's planner * fix(bug): fix a bug in linear regression and add some unit test for linear regression * chore: format code * feat: deal with NULL value in linear_regression * feat: add test for all value is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement
predict_linearfunction in promql and add some unit test. Extractlinear_regressionfromderiv.rstofunctions.rsfor reuse it in predict_linear.Checklist
Refer to a related PR or issue link (optional)
#1349