Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl literal only PromQL query #1641

Merged
merged 6 commits into from
May 26, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • refactor EmptyMetrics plan to accept an expr as data source
  • implement literal expression, and literal-only binary expression

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

part of #1042

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1641 (d3b6cc7) into develop (eb24bab) will decrease coverage by 0.56%.
The diff coverage is 58.38%.

@@             Coverage Diff             @@
##           develop    #1641      +/-   ##
===========================================
- Coverage    85.77%   85.21%   -0.56%     
===========================================
  Files          563      563              
  Lines        90135    90258     +123     
===========================================
- Hits         77314    76917     -397     
- Misses       12821    13341     +520     

Signed-off-by: Ruihang Xia <[email protected]>
@waynexia
Copy link
Member Author

A known format issue is tracked in #1642

Copy link
Collaborator

@etolbakov etolbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 0da9493 into GreptimeTeam:develop May 26, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* refactor EmptyMetric to accept expr

Signed-off-by: Ruihang Xia <[email protected]>

* impl literal only query

Signed-off-by: Ruihang Xia <[email protected]>

* add empty line

Signed-off-by: Ruihang Xia <[email protected]>

* clean up

Signed-off-by: Ruihang Xia <[email protected]>

* support literal on HTTP gateway

Signed-off-by: Ruihang Xia <[email protected]>

* fix clippy (again)

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants