refactor: merge catalog provider & schema provider into catalog manager #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
This was referenced Jun 21, 2023
2 tasks
Signed-off-by: Ruihang Xia <[email protected]>
|
All UT pass now. I'm going to resolve conflict and check other tests later. This is generally ready for review |
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1803 +/- ##
===========================================
- Coverage 86.45% 86.29% -0.17%
===========================================
Files 585 584 -1
Lines 95432 95048 -384
===========================================
- Hits 82509 82019 -490
- Misses 12923 13029 +106 |
v0y4g3r
reviewed
Jun 25, 2023
Signed-off-by: Ruihang Xia <[email protected]>
v0y4g3r
approved these changes
Jun 26, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…er (GreptimeTeam#1803) * move to expr_factory Signed-off-by: Ruihang Xia <[email protected]> * move configs into service_config Signed-off-by: Ruihang Xia <[email protected]> * move GrpcQueryHandler into distributed.rs Signed-off-by: Ruihang Xia <[email protected]> * fix compile and test in catalog sub-crate Signed-off-by: Ruihang Xia <[email protected]> * clean up Signed-off-by: Ruihang Xia <[email protected]> * fix table-procedure compile and test Signed-off-by: Ruihang Xia <[email protected]> * fix query compile and tests Signed-off-by: Ruihang Xia <[email protected]> * fix datanode compile and tests Signed-off-by: Ruihang Xia <[email protected]> * fix catalog/query/script/servers compile Signed-off-by: Ruihang Xia <[email protected]> * fix frontend compile Signed-off-by: Ruihang Xia <[email protected]> * fix nextest except information_schema Signed-off-by: Ruihang Xia <[email protected]> * support information_schema Signed-off-by: Ruihang Xia <[email protected]> * fix sqlness test Signed-off-by: Ruihang Xia <[email protected]> * fix merge errors Signed-off-by: Ruihang Xia <[email protected]> * remove other structs Signed-off-by: Ruihang Xia <[email protected]> * clean up Signed-off-by: Ruihang Xia <[email protected]> * fix format Signed-off-by: Ruihang Xia <[email protected]> * change deregister_table's return type to empty tuple Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Remove
CatalogProviderandSchemaProvider. Move all the necessary methods intoCatalogManager.Checklist
Refer to a related PR or issue link (optional)