feat: physical plan wrapper #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0361b51.
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
This reverts commit 672a013.
shuiyisong
requested review from
sunng87,
MichaelScofield,
waynexia and
fengys1996
sunng87
reviewed
Jun 27, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1837 +/- ##
===========================================
- Coverage 86.51% 86.24% -0.27%
===========================================
Files 587 587
Lines 95642 95670 +28
===========================================
- Hits 82745 82511 -234
- Misses 12897 13159 +262 |
MichaelScofield
approved these changes
Jun 27, 2023
sunng87
approved these changes
Jun 27, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* test: add physical plan wrapper trait * test: add plugins to datanode initialization * test: add plugins to datanode initialization * chore: add metrics method * chore: update meter-core version * chore: remove unused code * chore: impl metrics method on df execution plan adapter * chore: minor comment fix * chore: add retry in create table * chore: shrink keep lease handler buffer * chore: add etcd batch size warn * chore: try shrink * Revert "chore: try shrink" This reverts commit 0361b51. * chore: add create table backup time * add metrics in some interfaces Signed-off-by: Ruihang Xia <[email protected]> * calc elapsed time and rows Signed-off-by: Ruihang Xia <[email protected]> * chore: remove timer in scan batch * chore: add back stream metrics wrapper * chore: add timer to ready poll * chore: minor update * chore: try using df_plan.metrics() * chore: remove table scan timer * chore: remove scan timer * chore: add debug log * Revert "chore: add debug log" This reverts commit 672a013. * chore: use batch size as row count * chore: use batch size as row count * chore: tune code for pr * chore: rename to physical plan wrapper --------- Signed-off-by: Ruihang Xia <[email protected]> Co-authored-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly does
PhysicalPlanWrapperfor plan execution hookPluginstoDatafusionQueryEngineto getPhysicalPlanWrapperinexec_query_plansrc/common/query/src/physical_plan.rsto get correct row countChecklist
Refer to a related PR or issue link (optional)