fix: add sqlness tests for some promql function #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
waynexia
commented
Jun 27, 2023
| -- {test="two samples"} 0 | ||
| -- {test="three samples"} 0 | ||
| -- {test="uneven samples"} 0 | ||
| -- tql eval (60, 60, '1s') quantile_over_time(0, data[1m]); |
There was a problem hiding this comment.
result set is unstable, waiting for CeresDB/sqlness#57
etolbakov
reviewed
Jun 27, 2023
| @@ -885,8 +886,8 @@ impl PromPlanner { | |||
| ScalarFunc::Udf(PredictLinear::scalar_udf(t_expr)) | |||
| } | |||
| "holt_winters" => { | |||
| let sf_exp = match other_input_exprs.get(0) { | |||
| Some(DfExpr::Literal(ScalarValue::Float64(Some(sf)))) => *sf, | |||
| let sf_exp = match other_input_exprs.pop_front() { | |||
There was a problem hiding this comment.
Thanks for improving it. Looks much better than .get(0) 👍
Codecov Report
@@ Coverage Diff @@
## develop #1838 +/- ##
===========================================
- Coverage 86.53% 86.23% -0.31%
===========================================
Files 588 588
Lines 95684 95724 +40
===========================================
- Hits 82804 82550 -254
- Misses 12880 13174 +294 |
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
35 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* correct range manipulate exec fmt text Signed-off-by: Ruihang Xia <[email protected]> * fix partition requirement Signed-off-by: Ruihang Xia <[email protected]> * fix udf signature Signed-off-by: Ruihang Xia <[email protected]> * finilise Signed-off-by: Ruihang Xia <[email protected]> * ignore unstable ordered result Signed-off-by: Ruihang Xia <[email protected]> * add nan value test Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add sqlness tests for
Other test are not ported due to
TEMPLATEinterceptor CeresDB/sqlness#51Checklist
Refer to a related PR or issue link (optional)