-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial twcs impl #1851
Merged
Merged
feat: initial twcs impl #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0y4g3r
force-pushed
the
feat/twcs
branch
4 times, most recently
from
June 30, 2023 04:51
ccb6721
to
b4ffa07
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1851 +/- ##
===========================================
- Coverage 86.48% 86.17% -0.32%
===========================================
Files 595 596 +1
Lines 96640 97143 +503
===========================================
+ Hits 83582 83710 +128
- Misses 13058 13433 +375 |
killme2008
reviewed
Jul 2, 2023
evenyag
reviewed
Jul 3, 2023
waynexia
reviewed
Jul 3, 2023
v0y4g3r
added
docs-required
This change requires docs update.
C-performance
Category Performance
Size: L
labels
Jul 4, 2023
evenyag
reviewed
Jul 4, 2023
waynexia
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
evenyag
approved these changes
Jul 4, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: initial twcs impl * chore: rename SimplePicker to LeveledPicker * rename some structs * Remove Compaction strategy * make compaction picker a trait object * make compaction picker configurable for every region * chore: add some test for ttl * add some tests * fix: some style issues in cr * feat: enable twcs when creating tables * feat: allow config time window when creating tables * fix: some cr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds support for TWCS compaction strategy inspired by Cassandra.
In previous leveled time window compaction strategy, SST files are strictly splitted and aligned to time windows. This may cause read amplification especially when a SST file contains rows from multiple time windows, even the out-of-order data is sparse.
TWCS computes SST file time window by their max timestamps in that out-of-order time-series data is mostly history data, it only affects min timestamps.
After assigning files into time windows, we then traverse every window to ensure that:
TWCS can be enable with table options:
Checklist
Refer to a related PR or issue link (optional)
Fixes #1068