feat: Make heartbeat intervals configurable in Frontend and Datanode #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelScofield
approved these changes
Jul 3, 2023
|
@ccjeff great! However, the rustfmt check in CI is not passed, please fix it. |
WenyXu
approved these changes
Jul 3, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1864 +/- ##
===========================================
- Coverage 86.47% 86.24% -0.24%
===========================================
Files 589 589
Lines 95647 95654 +7
===========================================
- Hits 82714 82495 -219
- Misses 12933 13159 +226 |
Sry I didn't check the format earlier. I've updated to fix the rustfmt check. Thanks! |
|
@ccjeff welcome on board! |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…reptimeTeam#1864) * update frontend options and config * fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Updated frontend to unify the heartbeat task unit with data node (changing from seconds to milliseconds), also making the intervals configurable
Please explain IN DETAIL what the changes are in this PR and why they are needed:
updated instance/frontend to accommodate this change
Checklist
Refer to a related PR or issue link (optional)
close #1792