feat: compatible with postgres interval type #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2146 +/- ##
===========================================
- Coverage 84.84% 84.59% -0.26%
===========================================
Files 693 696 +3
Lines 109969 110479 +510
===========================================
+ Hits 93306 93459 +153
- Misses 16663 17020 +357 |
|
@sunng87 Please take a look. |
sunng87
reviewed
Aug 11, 2023
sunng87
approved these changes
Aug 11, 2023
|
@QuenKar Thank you! |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: impl ToSql/FromSql/ToSqlText for PgInterval. * chore: remove useless code. * feat: compatible with postgres interval type. * chore: cr comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
implement
common_time::intervalconvert to/frompostgres intervalusingPgIntervalChecklist
Refer to a related PR or issue link (optional)
#1952 (comment)
Closes: #2098