fix: several clippy error/warnings after upgrading toolchain #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
sunng87
approved these changes
Aug 11, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2156 +/- ##
===========================================
- Coverage 84.88% 84.59% -0.29%
===========================================
Files 694 695 +1
Lines 109966 110366 +400
===========================================
+ Hits 93344 93365 +21
- Misses 16622 17001 +379 |
waynexia
changed the title
discord9
approved these changes
Aug 11, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…eTeam#2156) * fix pyscripts mod Signed-off-by: Ruihang Xia <[email protected]> * fix clippy::needless-pass-by-ref-mut Signed-off-by: Ruihang Xia <[email protected]> * add pyo3 feature gate in Makefile Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
clippy::needless-pass-by-ref-mutChecklist
Refer to a related PR or issue link (optional)
rust toolchain is upgraded in #2049