-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flow): accumlator for aggr func #3396
Merged
fengjiachun
merged 14 commits into
GreptimeTeam:main
from
discord9:dataflow_p1_aggr_accum
Mar 12, 2024
Merged
feat(flow): accumlator for aggr func #3396
fengjiachun
merged 14 commits into
GreptimeTeam:main
from
discord9:dataflow_p1_aggr_accum
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discord9
force-pushed
the
dataflow_p1_aggr_accum
branch
from
February 27, 2024 08:54
114dcde
to
879131c
Compare
19 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
==========================================
+ Coverage 85.04% 85.07% +0.02%
==========================================
Files 893 908 +15
Lines 147899 151892 +3993
==========================================
+ Hits 125781 129218 +3437
- Misses 22118 22674 +556 |
zhongzc
reviewed
Feb 28, 2024
zhongzc
reviewed
Mar 1, 2024
zhongzc
reviewed
Mar 1, 2024
zhongzc
reviewed
Mar 1, 2024
zhongzc
reviewed
Mar 11, 2024
zhongzc
reviewed
Mar 11, 2024
zhongzc
reviewed
Mar 11, 2024
zhongzc
reviewed
Mar 11, 2024
zhongzc
reviewed
Mar 11, 2024
zhongzc
reviewed
Mar 11, 2024
zhongzc
reviewed
Mar 11, 2024
fengjiachun
reviewed
Mar 11, 2024
zhongzc
approved these changes
Mar 11, 2024
fengjiachun
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Added several types of accumlator to store all the needed information during streaming and accumlate data in a aggr func, note that those accumlator also record counts of non null value:
Bool
accumlator, counting numbers oftrue
andfalse
, for functions likeany
,all
,max(bool)
andmin(bool)
SimpleNumber
accumlator keep records of one singlei128
for functions likecount
andsum
for integer.Float
accumlator store a 64bit float number and counts of pos/neg inf&nans, forsum
with float numberOrdValue
accumlator store a single Value formin/max
Checklist
Refer to a related PR or issue link (optional)