Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove support for logical tables in the create table procedure #3592

Merged

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Mar 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said, since we already have the CreateLogicalTablesProcedure

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 27, 2024
@fengjiachun fengjiachun marked this pull request as draft March 27, 2024 07:42
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.01%. Comparing base (5addb7d) to head (a084a54).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
- Coverage   85.36%   85.01%   -0.36%     
==========================================
  Files         931      931              
  Lines      154702   154639      -63     
==========================================
- Hits       132065   131459     -606     
- Misses      22637    23180     +543     

@fengjiachun fengjiachun marked this pull request as ready for review March 27, 2024 09:15
@fengjiachun fengjiachun added the breaking-change This pull request contains breaking changes. label Mar 27, 2024
@github-actions github-actions bot removed the breaking-change This pull request contains breaking changes. label Mar 27, 2024
@fengjiachun fengjiachun added this pull request to the merge queue Mar 27, 2024
Merged via the queue into GreptimeTeam:main with commit 9428cb8 Mar 27, 2024
19 checks passed
@fengjiachun fengjiachun deleted the feat/rm-logical-from-create branch March 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants