Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Update RustPython to 0.3.1 #3723

Closed
wants to merge 1 commit into from

Conversation

youknowone
Copy link

#3063 draft

The code part looks done, but I believe @discord9 wants to change the dependency to the GC version.

@github-actions github-actions bot added docs-not-required This change does not impact docs. Invalid PR Title labels Apr 16, 2024
@tisonkun tisonkun changed the title Update RustPython to 0.3.1 build(deps): Update RustPython to 0.3.1 Apr 16, 2024
@tisonkun
Copy link
Collaborator

@youknowone welcome! Thanks for driving this effort.

@discord9
Copy link
Contributor

Really thank you for your effort, havin't found enough time to upgrade rustpython depend! I should very soon be able to switch to a GC-ed fork (although it's still bugged with at least one bug of method monkey-patch cause use-after-free could be due to some complex ref cycle, and I need to write something like obj-graph to found out about it), but at least it can pass those tests and not cause memory leak if not using too pythonic code...

@tisonkun
Copy link
Collaborator

We may move forward the GC support upstream and then upgrade RustPython version in GreptimeDB.

Thank @youknowone for your demostration, I successfully upgrade the parser part in another patch now. We'll pick up this patch once the RustPython upstream is in a state upgradable for GreptimeDB.

Closing for now since it won't have progress until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants