Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect time range when building parquet reader #3947

Merged
merged 5 commits into from
May 21, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented May 15, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR converts the desired time range into SimpleFilterContext while building parquet readers so that the reader can filter out those rows outside the desired time range.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@v0y4g3r v0y4g3r requested review from evenyag, waynexia and a team as code owners May 15, 2024 09:19
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 79.46429% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (4778575) to head (6defa14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3947      +/-   ##
==========================================
- Coverage   85.50%   85.17%   -0.33%     
==========================================
  Files         977      977              
  Lines      169344   169412      +68     
==========================================
- Hits       144793   144298     -495     
- Misses      24551    25114     +563     

@v0y4g3r v0y4g3r requested a review from fengjiachun May 17, 2024 08:03
src/table/src/predicate.rs Show resolved Hide resolved
src/table/src/table/adapter.rs Outdated Show resolved Hide resolved
src/mito2/src/read/scan_region.rs Outdated Show resolved Hide resolved
src/mito2/src/sst/parquet/reader.rs Show resolved Hide resolved
src/query/src/tests/time_range_filter_test.rs Outdated Show resolved Hide resolved
@v0y4g3r v0y4g3r requested a review from evenyag May 21, 2024 11:10
@evenyag evenyag added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@killme2008 killme2008 added this pull request to the merge queue May 21, 2024
Merged via the queue into GreptimeTeam:main with commit e070ba3 May 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants