Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): export metric physical tables first #3949

Merged
merged 2 commits into from
May 16, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 15, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Export metric physical tables first

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner May 15, 2024 13:09
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 53.48837% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 85.30%. Comparing base (cfae276) to head (1dad8da).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3949      +/-   ##
==========================================
- Coverage   85.70%   85.30%   -0.41%     
==========================================
  Files         969      972       +3     
  Lines      166649   166881     +232     
==========================================
- Hits       142834   142362     -472     
- Misses      23815    24519     +704     

src/cmd/src/cli/export.rs Outdated Show resolved Hide resolved
src/cmd/src/cli/export.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/export-metric-table-first branch from d9437f0 to 1dad8da Compare May 16, 2024 03:53
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue May 16, 2024
Merged via the queue into GreptimeTeam:main with commit c915916 May 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants