Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize channel information for sqlness tests #4729

Merged
merged 24 commits into from
Oct 4, 2024

Conversation

J0HN50N133
Copy link
Contributor

@J0HN50N133 J0HN50N133 commented Sep 16, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4679

What's changed and what's your intention?

As coderabbitai said

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced SQL commands for MySQL and PostgreSQL, enhancing database interaction capabilities.
    • Added configuration support for MySQL and PostgreSQL in the testing environment.
    • Implemented a protocol interceptor for SQL query execution, supporting "postgres" and "mysql" protocols.
  • Bug Fixes

    • Improved error handling for database connection and command execution.
  • Documentation

    • Enhanced comments and structure in SQL command files for better clarity and adherence to protocols.
  • Refactor

    • Updated connection management to support multiple server addresses for improved flexibility.

@J0HN50N133 J0HN50N133 requested a review from a team as a code owner September 16, 2024 09:02
Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce a comprehensive set of SQL commands and configurations for MySQL and PostgreSQL within the testing framework. New files are added to facilitate SQL query execution, and existing files are modified to enhance database connection management and protocol handling. Additionally, configuration templates are updated to support both database systems, and new structures are introduced to better manage server addresses and SQL protocol interactions.

Changes

File Path Change Summary
tests/cases/standalone/common/mysql.result Introduces SQL queries for MySQL, including transaction isolation level, version comment, and databases.
tests/cases/standalone/common/mysql.sql Adds SQL commands for MySQL to retrieve isolation level, version comment, and show databases.
tests/cases/standalone/common/system/pg_catalog.result Includes SQL commands related to PostgreSQL catalog, database creation, and table management.
tests/cases/standalone/common/system/pg_catalog.sql Enhances SQL commands for PostgreSQL catalog management and database operations.
tests/conf/standalone-test.toml.template Updates configuration to include new sections for MySQL and PostgreSQL database settings.
tests/runner/Cargo.toml Adds dependencies and workspace entries for datatypes, mysql, and tokio-postgres.
tests/runner/src/env.rs Modifies Env struct to manage multiple server addresses and update connection methods.
tests/runner/src/main.rs Introduces ServerAddr struct for organized server address handling in command-line arguments.
tests/runner/src/protocol_interceptor.rs Implements a new protocol interceptor for SQL query execution, managing protocol context.

Possibly related PRs

  • feat: add json data type #4619: The main PR introduces SQL queries for MySQL, while this retrieved PR adds a JSON data type to the database, which may involve similar SQL commands for querying JSON data in MySQL.

Suggested reviewers

  • WenyXu
  • waynexia

Poem

In the land of code with hops so bright,
New queries dance in the soft moonlight.
MySQL and PostgreSQL, side by side,
With configurations and protocols, we take pride.
Hooray for changes, let the tests run free,
A rabbit's joy in this code jubilee! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Sep 16, 2024
@J0HN50N133 J0HN50N133 changed the title feat: customize channel information for sqlness tests #4679 feat: customize channel information for sqlness tests Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (caf5f2c) to head (01f40dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4729      +/-   ##
==========================================
- Coverage   84.47%   84.21%   -0.27%     
==========================================
  Files        1120     1120              
  Lines      204110   204110              
==========================================
- Hits       172426   171895     -531     
- Misses      31684    32215     +531     

tests/runner/src/protocol_interceptor.rs Outdated Show resolved Hide resolved
tests/runner/src/protocol_interceptor.rs Outdated Show resolved Hide resolved
tests/runner/src/protocol_interceptor.rs Outdated Show resolved Hide resolved
tests/runner/src/env.rs Show resolved Hide resolved
tests/runner/src/env.rs Show resolved Hide resolved
tests/runner/src/env.rs Show resolved Hide resolved
@J0HN50N133
Copy link
Contributor Author

For some reason, the connection to PostgreSQL is closed in the CI environment. Does anyone have any idea?

@evenyag
Copy link
Contributor

evenyag commented Sep 23, 2024

@coderabbitai summary

Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Actions performed

Summary regeneration triggered.

@waynexia
Copy link
Member

merge main to update the lock file

tests/runner/src/main.rs Show resolved Hide resolved
tests/runner/Cargo.toml Show resolved Hide resolved
@J0HN50N133
Copy link
Contributor Author

@waynexia can we push forward this pr?

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move forward and create an issue to see if we can switch to sqlx.

@J0HN50N133 Please confirm the remaining comments and resolve the conflicts.

auto-merge was automatically disabled October 3, 2024 10:24

Head branch was pushed to by a user without write access

@tisonkun tisonkun added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@tisonkun tisonkun added this pull request to the merge queue Oct 4, 2024
Merged via the queue into GreptimeTeam:main with commit 47a3277 Oct 4, 2024
33 checks passed
@killme2008
Copy link
Contributor

@J0HN50N133 Thank you for your hard work and patience.

@waynexia
Copy link
Member

@waynexia can we push forward this pr?

Sorry for the delay. The idea behind preferring sqlx is it's wider accepted based on stats in crates.io, and thus is more aligned with end users. But this is not a hard requirement after all 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants