-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: customize channel information for sqlness tests #4729
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes introduce a comprehensive set of SQL commands and configurations for MySQL and PostgreSQL within the testing framework. New files are added to facilitate SQL query execution, and existing files are modified to enhance database connection management and protocol handling. Additionally, configuration templates are updated to support both database systems, and new structures are introduced to better manage server addresses and SQL protocol interactions. Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4729 +/- ##
==========================================
- Coverage 84.47% 84.21% -0.27%
==========================================
Files 1120 1120
Lines 204110 204110
==========================================
- Hits 172426 171895 -531
- Misses 31684 32215 +531 |
For some reason, the connection to PostgreSQL is closed in the CI environment. Does anyone have any idea? |
4501029
to
34b0bfa
Compare
@coderabbitai summary |
Actions performedSummary regeneration triggered. |
merge |
@waynexia can we push forward this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can move forward and create an issue to see if we can switch to sqlx.
@J0HN50N133 Please confirm the remaining comments and resolve the conflicts.
Co-authored-by: Yingwen <[email protected]>
fix: Cargo.lock conflict
Head branch was pushed to by a user without write access
e4ba54e
to
88f2996
Compare
@J0HN50N133 Thank you for your hard work and patience. |
Sorry for the delay. The idea behind preferring |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4679
What's changed and what's your intention?
As coderabbitai said
Checklist
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
Refactor