-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support to reject write after flushing #4759
feat: support to reject write after flushing #4759
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request introduces significant changes across various files, primarily focusing on renaming variables for consistency and clarity, updating dependency revisions, and modifying configurations related to region management. Notably, it adds a new target for migrating regions with local WAL, updates the handling of region leadership states, and enhances the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4759 +/- ##
==========================================
- Coverage 84.47% 84.18% -0.29%
==========================================
Files 1118 1120 +2
Lines 203093 203867 +774
==========================================
+ Hits 171571 171634 +63
- Misses 31522 32233 +711 |
7d8affc
to
89c35c5
Compare
89c35c5
to
608751f
Compare
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
@WenyXu Lots of conflicts. |
Interesting, I'm going to fix it 🥲 |
7d8bbda
to
5b86ad9
Compare
20b3e61
to
ed417ce
Compare
src/catalog/src/system_schema/information_schema/region_peers.rs
Outdated
Show resolved
Hide resolved
src/catalog/src/system_schema/information_schema/region_peers.rs
Outdated
Show resolved
Hide resolved
src/meta-srv/src/procedure/region_migration/downgrade_leader_region.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be LGTM once all the conversations are resolved.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Support to reject write after flushing
Checklist
Summary by CodeRabbit
New Features
fuzz_migrate_mito_regions
with a "Local WAL" mode for enhanced configuration.reject_write
field to theDowngradeRegion
struct for better management of write requests.Bug Fixes
Documentation
Refactor
leader_status
toleader_state
across multiple components for consistency and clarity.