Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to reject write after flushing #4759

Merged
merged 24 commits into from
Sep 30, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 23, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Support to reject write after flushing

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Summary by CodeRabbit

  • New Features

    • Introduced a new target fuzz_migrate_mito_regions with a "Local WAL" mode for enhanced configuration.
    • Added a reject_write field to the DowngradeRegion struct for better management of write requests.
  • Bug Fixes

    • Updated logic to set region roles more explicitly rather than managing writable states.
  • Documentation

    • Improved documentation comments for clarity, including updates to method descriptions.
  • Refactor

    • Renamed leader_status to leader_state across multiple components for consistency and clarity.

Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request introduces significant changes across various files, primarily focusing on renaming variables for consistency and clarity, updating dependency revisions, and modifying configurations related to region management. Notably, it adds a new target for migrating regions with local WAL, updates the handling of region leadership states, and enhances the DowngradeRegion struct with a new field. Several functions and tests are adjusted to reflect these changes, ensuring that the codebase maintains coherence in terminology and functionality.

Changes

File Path Change Summary
.github/workflows/develop.yml Added new target fuzz_migrate_mito_regions with "Local WAL" mode; modified enable-region-failover parameter.
Cargo.toml Updated greptime-proto dependency revision from 36334744c7020734dcb4a6b8d24d52ae7ed53fe1 to 0b4f7c8ab06399f6b90e1626e8d5b9697cb33bb9.
src/catalog/src/system_schema/information_schema/region_peers.rs Renamed variable leader_status to leader_state in InformationSchemaRegionPeersBuilder.
src/cmd/src/cli/bench.rs Renamed variable leader_status to leader_state in create_region_routes function.
src/common/meta/src/ddl/alter_table/region_request.rs Renamed variable leader_status to leader_state in the test module.
src/common/meta/src/ddl/tests/alter_table.rs Renamed field leader_status to leader_state in RegionRoute structure across test functions.
src/common/meta/src/ddl/tests/drop_table.rs Renamed field leader_status to leader_state in RegionRoute structure within the test function.
src/common/meta/src/instruction.rs Added new field reject_write to DowngradeRegion struct; updated Display implementation.
src/common/meta/src/key.rs Renamed RegionStatus to RegionState, updated function signatures and variable names accordingly.
src/common/meta/src/key/table_route.rs Modified test_table_route_compatibility to use structured data types for comparisons instead of string formatting.
src/common/meta/src/region_keeper.rs Updated documentation comment for register method in MemoryRegionKeeper.
src/common/meta/src/rpc/router.rs Renamed RegionStatus to RegionState, updated function signatures and logic related to region leadership states.
src/datanode/src/alive_keeper.rs Modified region role management logic in response to events, focusing on Follower and Leader roles.
src/datanode/src/datanode.rs Updated import statements to include RegionRole and modified handling of region roles in open_all_regions.

Possibly related PRs

  • feat: migrate local WAL regions #4715: The main PR introduces a new target for migrating regions with local WAL, while the retrieved PR focuses on enhancing the migration process for local WAL regions, indicating a direct connection in functionality.

Suggested reviewers

  • v0y4g3r
  • evenyag
  • waynexia
  • fengjiachun
  • MichaelScofield

🐇 In the code where rabbits play,
New names hop in without delay.
Regions now know their state so clear,
With roles defined, there's naught to fear.
From status to state, we leap and bound,
In this code garden, joy is found! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Sep 23, 2024
@WenyXu WenyXu marked this pull request as ready for review September 23, 2024 13:20
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 89.42308% with 77 lines in your changes missing coverage. Please review.

Project coverage is 84.18%. Comparing base (d6be44b) to head (622f32a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4759      +/-   ##
==========================================
- Coverage   84.47%   84.18%   -0.29%     
==========================================
  Files        1118     1120       +2     
  Lines      203093   203867     +774     
==========================================
+ Hits       171571   171634      +63     
- Misses      31522    32233     +711     

@WenyXu WenyXu force-pushed the feat/enhance-region-migrating branch 2 times, most recently from 7d8affc to 89c35c5 Compare September 25, 2024 07:23
@WenyXu WenyXu marked this pull request as draft September 25, 2024 07:57
@WenyXu WenyXu force-pushed the feat/enhance-region-migrating branch from 89c35c5 to 608751f Compare September 25, 2024 07:58
@WenyXu WenyXu marked this pull request as ready for review September 27, 2024 08:12
@WenyXu
Copy link
Member Author

WenyXu commented Sep 27, 2024

@coderabbitai summary

Copy link
Contributor

coderabbitai bot commented Sep 27, 2024

✅ Actions performed

Summary regeneration triggered.

@killme2008
Copy link
Contributor

@WenyXu Lots of conflicts.

@WenyXu
Copy link
Member Author

WenyXu commented Sep 28, 2024

@WenyXu Lots of conflicts.

Interesting, I'm going to fix it 🥲

@WenyXu WenyXu force-pushed the feat/enhance-region-migrating branch from 7d8bbda to 5b86ad9 Compare September 28, 2024 02:40
src/common/meta/src/rpc/router.rs Outdated Show resolved Hide resolved
src/common/meta/src/rpc/router.rs Outdated Show resolved Hide resolved
src/datanode/src/alive_keeper.rs Outdated Show resolved Hide resolved
src/datanode/src/alive_keeper.rs Outdated Show resolved Hide resolved
src/datanode/src/heartbeat/handler/downgrade_region.rs Outdated Show resolved Hide resolved
src/mito2/src/worker.rs Show resolved Hide resolved
src/store-api/src/region_engine.rs Outdated Show resolved Hide resolved
src/mito2/src/flush.rs Outdated Show resolved Hide resolved
src/mito2/src/region.rs Outdated Show resolved Hide resolved
src/mito2/src/region.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/enhance-region-migrating branch from 20b3e61 to ed417ce Compare September 30, 2024 03:44
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
src/common/meta/src/rpc/router.rs Outdated Show resolved Hide resolved
src/common/meta/src/rpc/router.rs Outdated Show resolved Hide resolved
src/datanode/src/heartbeat/handler/downgrade_region.rs Outdated Show resolved Hide resolved
src/datanode/src/heartbeat/handler/downgrade_region.rs Outdated Show resolved Hide resolved
src/datanode/src/region_server.rs Outdated Show resolved Hide resolved
src/mito2/src/flush.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be LGTM once all the conversations are resolved.

@WenyXu WenyXu added this pull request to the merge queue Sep 30, 2024
Merged via the queue into GreptimeTeam:main with commit 6e776d5 Sep 30, 2024
33 checks passed
@WenyXu WenyXu deleted the feat/enhance-region-migrating branch September 30, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants