chore: make sure aws-lc-sys wouldn't be built #4767
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughA new step has been introduced in the GitHub Actions workflow located in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4767 +/- ##
==========================================
- Coverage 84.55% 84.28% -0.27%
==========================================
Files 1117 1117
Lines 202684 202684
==========================================
- Hits 171370 170826 -544
- Misses 31314 31858 +544 |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/develop.yml (1)
272-274: LGTM! Consider a minor improvement for clarity.The new step effectively checks for the presence of
aws-lc-sysin the dependency tree, which aligns with the PR objective of preventing its accidental building. This is a good addition to the workflow.To improve clarity and address a potential issue flagged by the static analysis tool, consider restructuring the command slightly:
- run: cargo tree -i aws-lc-sys -e features | grep aws-lc-sys && echo "Found aws-lc-sys, due to it having problem compiling on older gcc and etc. for now, please replace it with ring for now until it improve it's building experience" && exit 1 || true + run: | + if cargo tree -i aws-lc-sys -e features | grep -q aws-lc-sys; then + echo "Found aws-lc-sys, which has compilation problems on older gcc versions. Please replace it with ring until its building experience improves." + exit 1 + fiThis restructuring:
- Makes the logic more explicit.
- Avoids the potential ambiguity of
A && B || Cflagged by the static analysis tool.- Removes the need for the
|| trueat the end, as the script will naturally exit with 0 ifaws-lc-sysis not found.🧰 Tools
actionlint
274-274: shellcheck reported issue in this script: SC2015:info:1:228: Note that A && B || C is not if-then-else. C may run when A is true
(shellcheck)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- .github/workflows/develop.yml (1 hunks)
🧰 Additional context used
actionlint
.github/workflows/develop.yml
274-274: shellcheck reported issue in this script: SC2015:info:1:228: Note that A && B || C is not if-then-else. C may run when A is true
(shellcheck)
discord9
force-pushed
the
check_no_aws_lc_sys
branch
from
524374a
to
1287c32
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4750
What's changed and what's your intention?
Make sure
aws-lc-syswouldn't accidentially be built.After update rustls to
0.23, it switch it's crypto lib toaws-lc, however, it's wrapper crateaws-lc-syshave many building problems on different platform due to chore with gcc version and etc, and currently it will fail building on our CentOS image, and possibly on andorid, so add a check to avoid bring inaws-lc-sysdepend before they solve most of the building problem. Have already test it locally by removing patches forrustls,hyper-rustlsandtokio-rusltsand this check will detectaws-lc-sysdependencyAlternative
Switch back to
rustls0.22, however that might not be feasible, since some of our dependenices might have move to higher version ofrustlswithout knowing this change of default on crypto library and it's building problems.Checklist
Summary by CodeRabbit
aws-lc-syscrate.aws-lc-syson older GCC versions, suggesting alternatives.