-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Merge sort Logical plan #4768
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4768 +/- ##
==========================================
- Coverage 84.54% 84.17% -0.38%
==========================================
Files 1117 1124 +7
Lines 202644 204759 +2115
==========================================
+ Hits 171329 172359 +1030
- Misses 31315 32400 +1085 |
Not very sure about the new sqlness result, apprently I'm missing a TopK in |
Co-authored-by: Lei, HUANG <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add a merge sort logical plan that for now does the same thing as before(same physical plan), but means need to do a proper merge sort here in the future
MergeSortLogicalPlan
that one day can be use to optimize sort pushdownMergeSortExtensionPlanner
to make it just translate toSortExec
physical plan just like before, and this Planner happens after DistExtensionPlannerSort
ConditionalCommutative
so it can be translate to MergeSortChecklist