Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Limit CPU in runtime (#3685) #4782

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

ActivePeter
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3685

What's changed and what's your intention?

  • Add parking_lot in root Cargo.toml, use parking_lot.workspace = true in sub project.
  • Expand the runtime with optional resource limitation level.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Copy link
Contributor

coderabbitai bot commented Sep 28, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Sep 28, 2024
@v0y4g3r
Copy link
Contributor

v0y4g3r commented Sep 28, 2024

@fengys1996 Please also take a look at this PR, aiming to provide a new relaxed runtime to constrain CPU usage of spawned tasks.

Cargo.toml Outdated Show resolved Hide resolved
src/common/runtime/scripts/draw.py Outdated Show resolved Hide resolved
src/common/runtime/src/future_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/future_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/ratelimit.rs Outdated Show resolved Hide resolved
@fengys1996
Copy link
Contributor

fengys1996 commented Sep 29, 2024

It looks like there are some conflicts and some compilation errors. Please resolve them first.

src/common/runtime/src/runtime.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime.rs Show resolved Hide resolved
src/common/runtime/src/future_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/future_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/future_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/future_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/future_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime.rs Show resolved Hide resolved
src/common/runtime/src/runtime_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttle_count_mode.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a document to describe how this runtime works and how to find a proper priority for the runtime? I'd suggest providing more docs in the runtime crate.

src/common/runtime/README Outdated Show resolved Hide resolved
src/common/runtime/src/lib.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/.gitignore Outdated Show resolved Hide resolved
src/common/runtime/src/lib.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttle_count_mode.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime.rs Show resolved Hide resolved
src/common/runtime/src/runtime_throttle_count_mode.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 53.18560% with 169 lines in your changes missing coverage. Please review.

Project coverage is 83.92%. Comparing base (5d42e63) to head (c69b984).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4782      +/-   ##
==========================================
- Coverage   84.24%   83.92%   -0.32%     
==========================================
  Files        1131     1134       +3     
  Lines      208879   209212     +333     
==========================================
- Hits       175976   175591     -385     
- Misses      32903    33621     +718     

src/common/runtime/src/bin.rs Outdated Show resolved Hide resolved
src/common/runtime/README Outdated Show resolved Hide resolved
src/common/runtime/src/bin.rs Outdated Show resolved Hide resolved
src/common/runtime/src/bin.rs Outdated Show resolved Hide resolved
src/common/runtime/README Outdated Show resolved Hide resolved
src/common/runtime/src/bin.rs Outdated Show resolved Hide resolved
src/common/runtime/README Outdated Show resolved Hide resolved
src/common/runtime/resources/rdme-exp.png Outdated Show resolved Hide resolved
src/common/runtime/src/bin.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttleable.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttleable.rs Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttleable.rs Outdated Show resolved Hide resolved
src/common/runtime/README Outdated Show resolved Hide resolved
src/common/runtime/README Outdated Show resolved Hide resolved
src/common/runtime/src/runtime_throttleable.rs Outdated Show resolved Hide resolved
src/common/runtime/src/bin.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are some remaining enhancements we can acheive in other PRs. e.g. Making tokens of different priorities configurable.

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r
Copy link
Contributor

v0y4g3r commented Oct 24, 2024

@fengys1996 I think we can test this feature on the new version of GreptimeDB edge now to see if it can manage the total CPU usage.

@v0y4g3r v0y4g3r added this pull request to the merge queue Oct 24, 2024
Merged via the queue into GreptimeTeam:main with commit 9d3ee63 Oct 24, 2024
41 checks passed
@killme2008
Copy link
Contributor

Great work! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants